-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix link and improve wording #38
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
This PR (HEAD: 1e46612) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/blog/+/235897 to see it. Tip: You can toggle comments from me using the |
Message from Gobot Gobot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/235897. |
Message from Ian Lance Taylor: Patch Set 1: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/235897. |
Message from Bryan C. Mills: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/235897. |
Message from Bryan C. Mills: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/235897. |
Message from si drake: Patch Set 1:
After rewriting it a couple of times, I came up with the following. It's slightly different from your recommendation, but uses the same sort of language. Thoughts?
Please don’t reply on this GitHub thread. Visit golang.org/cl/235897. |
Message from si drake: Patch Set 1: I've updated the Commit messages has also been amended as per the link sent. Please don’t reply on this GitHub thread. Visit golang.org/cl/235897. |
Message from si drake: Patch Set 1: (3 comments) Do I need to do something to have this re-reviewed, after addressing the comments, or is it just a waiting game? Please don’t reply on this GitHub thread. Visit golang.org/cl/235897. |
Message from Ian Lance Taylor: Patch Set 1: I'm not seeing your changes. Are you sure that you pushed them? Thanks. Please don’t reply on this GitHub thread. Visit golang.org/cl/235897. |
This PR (HEAD: ce40f1a) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/blog/+/235897 to see it. Tip: You can toggle comments from me using the |
Message from si drake: Patch Set 1:
Not sure what happened there, but it doesn't look like I comitted the changes (or I somehow rebased them out). I've updated again and comitted. Let me know if there are any further changes to make. Please don’t reply on this GitHub thread. Visit golang.org/cl/235897. |
Message from Ian Lance Taylor: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/235897. |
This PR (HEAD: 8ae6098) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/blog/+/235897 to see it. Tip: You can toggle comments from me using the |
This PR (HEAD: 1103f71) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/blog/+/235897 to see it. Tip: You can toggle comments from me using the |
This PR (HEAD: 5216487) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/blog/+/235897 to see it. Tip: You can toggle comments from me using the |
Message from si drake: Patch Set 5: (1 comment) Should be good for another review at your leisure. Please don’t reply on this GitHub thread. Visit golang.org/cl/235897. |
Message from Bryan C. Mills: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/235897. |
Message from si drake: Patch Set 5: I just did a little bit of research afer Bryan's last comment and it looks like my understanding, of what that block of code does, was wrong. Without dragging this on, I think I might be able to add some extra context to this paragraph for future readers so they don't have the same misunderstanding. How does that sound? Do you normally have some sort of timeframe for these? Please don’t reply on this GitHub thread. Visit golang.org/cl/235897. |
- Fix the `time.After` link so it shows properly - Improve the wording describing the `Query` function, so it's clearer to readers.
This PR (HEAD: 82fd5c2) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/blog/+/235897 to see it. Tip: You can toggle comments from me using the |
Message from si drake: Patch Set 5: OK I've pushed another patch. It's actually VERY similar to Bryan's, as I took some of the wording, but I think the reference to the result not being immediately available from Also perfectly happy to just go ahead with Bryan's last suggestion in it's entirety. Please don’t reply on this GitHub thread. Visit golang.org/cl/235897. |
Message from Ian Lance Taylor: Patch Set 6: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/235897. |
Message from Go Bot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/235897. |
This PR is being closed because golang.org/cl/235897 has been abandoned. Closing because the content of x/blog moved to x/website (see CL 324270). If this change still applies, it'd need to be re-sent it to x/website. Thanks. |
time.After
link so it shows properlyQuery
function, so it's clearer to readers.