Article page: make title not clickable #50
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR (HEAD: c681c76) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/blog/+/318269 to see it. Tip: You can toggle comments from me using the |
|
This PR is being closed because golang.org/cl/318269 has been abandoned. Closing because the content of x/blog moved to x/website (see CL 324270). If this change still applies, it'd need to be re-sent it to x/website. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem we solve with this pull request: this is a bad UX to have links to the current page - no value to click and wait to page reload. Also now black font color on article page shows that this is an article page, not main page (useful for full screen mode).
Maybe my code is wrong, maybe
<i class="IsArticle"></i>is stupid and we need to pass args through Go template, please feel free to fix. I do not know how to add conditional rendering toblog/_template/root.tmpl
Line 203 in efbf96d