-
Notifications
You must be signed in to change notification settings - Fork 18.3k
errors: omit redundant nil check in type assertion for Join #74764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
When ok is true, err can't be nil. Make it behave more like the Unwrap function. Change-Id: I40f3688b377b8a26c95f659406150e5deb42b329
This PR (HEAD: 6df9365) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/689920. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/689920. |
Message from Jes Cok: Patch Set 1: Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/689920. |
Message from Go LUCI: Patch Set 1: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-07-26T02:58:30Z","revision":"97c98a44cc04dc21afb4226b733c7ca19d10c5fb"} Please don’t reply on this GitHub thread. Visit golang.org/cl/689920. |
Message from Jes Cok: Patch Set 1: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/689920. |
Message from Go LUCI: Patch Set 1: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/689920. |
Message from Go LUCI: Patch Set 1: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/689920. |
Message from Jorropo: Patch Set 1: Auto-Submit+1 Code-Review+2 Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/689920. |
Message from Go LUCI: Patch Set 1: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-07-26T03:31:48Z","revision":"97c98a44cc04dc21afb4226b733c7ca19d10c5fb"} Please don’t reply on this GitHub thread. Visit golang.org/cl/689920. |
Message from Jorropo: Patch Set 1: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/689920. |
Message from Go LUCI: Patch Set 1: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/689920. |
Message from Keith Randall: Patch Set 1: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/689920. |
When ok is true, err can't be nil.
Make it behave more like the Unwrap function.