Skip to content

benchfmt: return an error in case of a non UTF-8 encoded file #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −0
Open

benchfmt: return an error in case of a non UTF-8 encoded file #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions benchfmt/reader.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,11 @@ func (r *Reader) Scan() bool {
r.result.line++
// We do everything in byte buffers to avoid allocation.
line := r.s.Bytes()
// We only accept utf-8 encoded files.
if !utf8.Valid(line) {
r.err = fmt.Errorf("%s: invalid encode, only utf-8 encoded files are supported", r.result.fileName)
return false
}
// Most lines are benchmark lines, and we can check
// for that very quickly, so start with that.
if bytes.HasPrefix(line, benchmarkPrefix) {
Expand Down