Remove the section about deprecating a record's constructor. #1863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
I no longer think that we should encourage people to fight the language like this. The constructor of a record is always as visible as the record. That's how the language is. If it doesn't suit a particular case, then don't use records in that case. RELNOTES=n/a PiperOrigin-RevId: 696285685
copybara-service
bot
force-pushed
the
test_main_696272639
branch
from
3580613 to
f34463c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the section about deprecating a record's constructor.
I no longer think that we should encourage people to fight the language like this.
The constructor of a record is always as visible as the record. That's how the language is.
If it doesn't suit a particular case, then don't use records in that case.
RELNOTES=n/a