[Refactor]: Move ProvisionMethods#create()/InjectionSiteMethods#create() into the generator that uses it.
#4516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
…eate()` into the generator that uses it. Note: this CL shouldn't cause any changes to the generated code. `FactoryGenerator` is the only class that uses `ProvisionMethods#create()`, and `MembersInjectorGenerator` is the only class that uses `InjectionSiteMethods#create()`. Thus, I'm moving these methods into these classes for better encapsulation. This will also make the XPoet migration easier since I plan to migrate `FactoryGenerator` and `MembersInjectorGenerator` separately. Note that these methods were sharing some logic that now needs to be duplicated, but IMO this creates more readable code since we're no longer entangling the two use cases. For example, now that `ProvisionMethods` and `InjectionSiteMethods` define their own versions of `methodProxy()` method, we no longer need the multiple enums (i.e. `InstanceCastPolicy` and `CheckNotNullPolicy`) as input to these methods. RELNOTES=N/A PiperOrigin-RevId: 700035303
copybara-service
bot
force-pushed
the
test_686601333
branch
from
72e3950 to
fdbc63e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Refactor]: Move
ProvisionMethods#create()/InjectionSiteMethods#create()into the generator that uses it.Note: this CL shouldn't cause any changes to the generated code.
FactoryGeneratoris the only class that usesProvisionMethods#create(), andMembersInjectorGeneratoris the only class that usesInjectionSiteMethods#create(). Thus, I'm moving these methods into these classes for better encapsulation. This will also make the XPoet migration easier since I plan to migrateFactoryGeneratorandMembersInjectorGeneratorseparately.Note that these methods were sharing some logic that now needs to be duplicated, but IMO this creates more readable code since we're no longer entangling the two use cases. For example, now that
ProvisionMethodsandInjectionSiteMethodsdefine their own versions ofmethodProxy()method, we no longer need the multiple enums (i.e.InstanceCastPolicyandCheckNotNullPolicy) as input to these methods.RELNOTES=N/A