Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playwrite DE Grund: Version 1.003 added #8939

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

vv-monsalve
Copy link
Collaborator

@vv-monsalve vv-monsalve commented Jan 16, 2025

Taken from the upstream repo https://github.com/TypeTogether/Playwrite at commit TypeTogether/Playwrite@c92b72c.

Resolves #8842

PR Checklist:

  • minisite_url definition in the METADATA.pb file for commissioned projects
  • tags are added for NEW FONTS
  • primary_script definition in the METADATA.pb file for all projects that have a primary non-Latin based language support target
  • subsets definitions in the METADATA.pb reflect the actual subsets and languages present in the font files (in alphabetic order). For CJK fonts, only include one of the following subsets chinese-hongkong, chinese-simplified, chinese-traditional, korean, japanese.
  • Fontbakery checks are reviewed and failing checks are resolved in collaboration with the upstream font development team
  • Diffenator2 regression checks for revisions on all projects that are currently in production
  • Designers bio info have to be present in the designer catalog (at least an issue should be opened for tracking this, if they are not)
  • Check designers order in metadata.pb, since the first one of the list appears as “principal designer”
  • Social media formatted visual assets for all new commissioned projects in the Drive directory, communicate with the repository Maintainer so that they can push this content to the Social Media tracker spreadsheet
  • Social media content draft for all new commissioned projects in the Drive directory and Social Media tracker spreadsheet, communicate with the repository Maintainer so that they can push this content to the Social Media tracker spreadsheet

@vv-monsalve vv-monsalve requested review from emmamarichal and removed request for emmamarichal January 16, 2025 17:30
@m4rc1e m4rc1e merged commit b3faa89 into main Jan 23, 2025
4 of 8 checks passed
@m4rc1e m4rc1e deleted the gftools_packager_ofl_playwritedegrund branch January 23, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Sandbox
Development

Successfully merging this pull request may close these issues.

Update DE Grund [Deutschland Grundschrift]
2 participants