Skip to content

Update installfrompip.adoc #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

r3motecontrol
Copy link

@r3motecontrol r3motecontrol commented Nov 7, 2016

When GRR is installed with pip in virtual environment, the path to default grr-server file is /grr/debian/grr-server.default. I could not find the file /etc/default/grr-server.
image

image

When GRR is installed with pip in virtual environment, the path to default grr-server is present in /grr/debian/grr-server.default. I could not find the file /etc/default/grr-server.
Copy link
Contributor

@destijl destijl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for going to the effort of submitting a PR!

@@ -97,7 +97,7 @@ pip install --editable grr/config/grr-response-server
pip install --no-cache-dir -f https://storage.googleapis.com/releases.grr-response.com/index.html grr-response-templates
pip install --editable grr/config/grr-response-test
----
Then edit /etc/default/grr-server and set:
Then edit /grr/debian/grr-server.default and set:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this path is set by the deb package. If you're just installing from pip you don't need to mess with this at all (but you need to do your own systemd setup, or run the worker, ui etc. manually. If you want to have all the systemd stuff set up for you by the package, then install a new version from source, you need to change this to update the systemd scripts.

So I don't think this needs changing but we need to clarify that somehow.

@@ -72,12 +72,12 @@ system:
sudo apt-get install build-essential uuid-dev zlib1g-dev python-dev
--------------------------------------------------------------------

Download protobuf version 2.5.0 or later from link:http://code.google.com/p/protobuf/[protobuf]
Download protobuf version 3.0.0 or later from link:http://code.google.com/p/protobuf/[protobuf]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you actually only need the compiler, so you can just go to the releases page and download the relevant compiler package for your OS.

Copy link
Author

@r3motecontrol r3motecontrol Nov 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @destijl

When I installed the compiler using sudo apt install protobuf-compiler, (Ubuntu 16.04), it installed v2.5.0. In the next step, cd /grr, pip install -editable . it produced an error "v3.0.0 required", After the installed protobuf-3.0.0, I was able to successfully install GRR. So I submitted the PR. I will verify it once again.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants