Added ability to serialize down Anon and Local classes #1589
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@googlebot I signed it! |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
It would probably also be good to but a warning on the GsonBuilder method because (de-)serializing anonymous or local classes can easily go wrong if they capture local variables or access members of the enclosing class.
See also #1510.
| /** | ||
| * Configures Gson to include local and/or anonymous classes for serialization | ||
| * @return a reference to this {@code GsonBuilder} object to fulfill the "Builder" pattern | ||
| * @since 2.1 |
There was a problem hiding this comment.
This is wrong, but has to be adjusted anyways depending on when this is merged.
| * @return a reference to this {@code GsonBuilder} object to fulfill the "Builder" pattern | ||
| * @since 2.1 | ||
| */ | ||
| public GsonBuilder enableLocalOrAnonClassSerialization(){ |
There was a problem hiding this comment.
| public GsonBuilder enableLocalOrAnonClassSerialization(){ | |
| public GsonBuilder enableLocalOrAnonClassSerialization() { |
I think there should be a space to match the style of the rest of the project.
| @@ -87,6 +88,12 @@ public Excluder disableInnerClassSerialization() { | |||
| return result; | |||
| } | |||
|
|
|||
| public Excluder enableAnonOrLocalClassSerialization(){ | |||
There was a problem hiding this comment.
| public Excluder enableAnonOrLocalClassSerialization(){ | |
| public Excluder enableAnonOrLocalClassSerialization() { |
I placed a flag in GsonBuilder that allows the Excluder to serialize Anon and Local classes down during the serialization to JSON. By default, the flag is false, and therefore won't break any existing usages of the Excluder.