Skip to content

Commit

Permalink
Include operator<<() for StringPiece in libre2.so
Browse files Browse the repository at this point in the history
operator<<() for StringPiece was moved under namespace re2 in an
earlier refactoring, but the exported symbols weren't updated with
the new mangled name.

Change-Id: If113a21d1ee136d06055e63ff89e486b73e07407
Reviewed-on: https://code-review.googlesource.com/29410
Reviewed-by: Paul Wankadia <[email protected]>
  • Loading branch information
kellerb authored and junyer committed Jun 24, 2018
1 parent 2def565 commit b277f4c
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 9 deletions.
4 changes: 2 additions & 2 deletions libre2.symbols
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
# re2::StringPiece*
_ZN3re211StringPiece*;
_ZNK3re211StringPiece*;
# operator<<(std::ostream&, re2::StringPiece const&)
_ZlsRSoRKN3re211StringPieceE;
# re2::operator<<*
_ZN3re2ls*;
# re2::FilteredRE2*
_ZN3re211FilteredRE2*;
_ZNK3re211FilteredRE2*;
Expand Down
9 changes: 2 additions & 7 deletions libre2.symbols.darwin
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,8 @@ __ZNK3re23RE2*
# re2::StringPiece*
__ZN3re211StringPiece*
__ZNK3re211StringPiece*
# operator<<(std::ostream&, re2::StringPiece const&)
# Seen with libstdc++ on 10.8 and below:
# __ZlsRSoRKN3re211StringPieceE
# Seen with libc++ on 10.9 and above:
# __ZlsRNSt3__113basic_ostreamIcNS_11char_traitsIcEEEERKN3re211StringPieceE
# Note that "ls" means operator<<, so this is not overly broad.
__Zls*RKN3re211StringPieceE
# re2::operator<<*
__ZN3re2ls*
# re2::FilteredRE2*
__ZN3re211FilteredRE2*
__ZNK3re211FilteredRE2*

0 comments on commit b277f4c

Please sign in to comment.