Add GA tracking for RRM CTA placement settings #10456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build files for fd06cda have been deleted. |
|
Size Change: +385 B (+0.02%) Total Size: 2.09 MB ℹ️ View Unchanged
|
1 task
techanvil
requested changes
Mar 21, 2025
There was a problem hiding this comment.
Hey @nfmohit, this is looking good, with the caveat that I think we should modify the approach for tracking these events, but as mentioned in a separate comment we can address that in a followup issue.
I have left a few minor comments to address here, please take a look.
assets/js/modules/reader-revenue-manager/components/settings/SettingsForm.js
Outdated
Show resolved
Hide resolved
assets/js/modules/reader-revenue-manager/components/settings/SettingsEdit.test.js
Outdated
Show resolved
Hide resolved
assets/js/modules/reader-revenue-manager/components/settings/SettingsEdit.test.js
Outdated
Show resolved
Hide resolved
assets/js/modules/reader-revenue-manager/components/settings/SettingsEdit.test.js
Outdated
Show resolved
Hide resolved
| const publicationAvailable = useSelect( ( select ) => { | ||
| if ( hasModuleAccess === undefined ) { | ||
| return undefined; | ||
| // Track GA event when snippet mode or post types change. |
There was a problem hiding this comment.
This is not a great approach for tracking the events. It's hard to reuse and maintain, and it could be easy to introduce a bug here in future.
It meets the AC and IB, so considering where we are time-wise I'm not going to suggest changing it here, but we should refactor this to use an approach where the event tracking is more directly tied to the save action.
I do gather the IB initially specced tracking these event in the datastore, I think this would be fine but as @hussain-t pointed out there's no easy way to provide the view context to these events from the datastore at present. However, we do have an issue in the pipeline to create a selector for retrieving the view context.
Anyhow, as mentioned let's leave this for now, I've created a followup issue where we can address the above: #10502
There was a problem hiding this comment.
I agree with the above. Thank you for opening the new issue 🙇
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
Relevant technical choices
This PR adds opt-in GA event tracking for the new Reader Revenue Manager CTA placement settings.
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist