Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence -Wdeprecated warning on clang #59

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

HowardHinnant
Copy link
Contributor

  • definition of implicit copy constructor for 'SnappySinkAllocator'
    is deprecated because it has a user-declared destructor.

* definition of implicit copy constructor for 'SnappySinkAllocator'
  is deprecated because it has a user-declared destructor.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot. The email used to register you as an authorized contributor must be the email used for the Git commit.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@HowardHinnant
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@cmumford
Copy link
Contributor

@googlebot rescan

@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@Quuxplusone
Copy link
Contributor

This warning is still happening in main. I confirm that Howard's fix is the appropriate fix.

snappy.cc:2344:3: error: definition of implicit copy constructor for 'SnappySinkAllocator' is deprecated
because it has a user-provided destructor [-Werror,-Wdeprecated-copy-with-user-provided-dtor]
 2344 |   ~SnappySinkAllocator() {}
      |   ^
snappy.cc:2194:9: note: in implicit copy constructor for 'snappy::SnappySinkAllocator'
first required here
 2194 |       : allocator_(allocator),
      |         ^
snappy.cc:2391:46: note: in instantiation of member function
'snappy::SnappyScatteredWriter<snappy::SnappySinkAllocator>::SnappyScatteredWriter' requested here
 2391 |   SnappyScatteredWriter<SnappySinkAllocator> writer(allocator);
      |                                              ^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants