Use quiet-ci Logger In Non-Interactive Environments
#942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Like with CI, running wireit in a non-TTY environment does not properly support the spinner and overwriting lines. We should use the QuietCiLogger in this case to present better output.
augustjk
reviewed
Oct 25, 2023
Co-authored-by: Augustine Kim <[email protected]>
Co-authored-by: Augustine Kim <[email protected]>
rictic
approved these changes
Oct 27, 2023
There was a problem hiding this comment.
This seems like an improvement.
As an aside, running multiple wireit scripts in parallel from another runner (like pnpm --filter) is supported but will be suboptimal, because it will invoke wireit repeatedly, run cross-package dependencies multiple times, re-check caches, schedule too much simultaneous work, etc
It will generally be more optimal to use a single runner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a repository that uses PNPM and makes heavy use of the
--filtersyntax for running scripts concurrently across different projects. Each of these scripts are ran non-interactively and so the progress spinner and line writeover result in useless output. We can remedy this by checking forprocess.stdout.isTTYin addition toprocess.env.CIwhen deciding what the default logger should be.