Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Translate & Modernise Clustering Algorithm module. #498

Merged
merged 1 commit into from
Oct 8, 2024
Merged

refactor: Translate & Modernise Clustering Algorithm module. #498

merged 1 commit into from
Oct 8, 2024

Conversation

iHackSubhodip
Copy link
Collaborator

Description:

  1. Translate & Modernised GMUNonHierarchicalDistanceBasedAlgorithm, GMUClusterItemQuadItem
  2. Translate & Modernise GMUClusterAlgorithmTest, GMUNonHierarchicalDistanceBasedAlgorithmTest, GMUGridBasedClusterAlgorithmTest Unit Test.
  3. Variable type correction in GMUGridBasedClusterAlgorithm1 class.

Reference:

Translate & Modified files, Adding Obj-C file for reference:

  1. GMUNonHierarchicalDistanceBasedAlgorithm
  2. GMUClusterItemQuadItem
  3. GMUClusterAlgorithmTest
  4. GMUNonHierarchicalDistanceBasedAlgorithmTest
  5. GMUGridBasedClusterAlgorithmTest

Validations:

Screenshot 2024-10-06 at 6 03 19 PM Screenshot 2024-10-06 at 6 04 00 PM

wangela
wangela approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@wangela wangela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the self-review based on bugs revealed by our unit tests.

@iHackSubhodip iHackSubhodip merged commit b25f7fe into feature/Cluster-Swift Oct 8, 2024
5 checks passed
@iHackSubhodip iHackSubhodip deleted the SB/Cluster-Phase-5-Swift branch October 8, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangela wangela wangela approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iHackSubhodip @wangela