Skip to content

Commit

Permalink
[FIX] payment_buckaroo: copy values dict to avoid altering original dict
Browse files Browse the repository at this point in the history
_buckaroo_generate_digital_sign uses the values dict to generate the shasign
At some point, it alters the dict, it removes BRQ_SIGNATURE, but, as the values dict was not copied, it altered the original dict.
So, the key BRQ_SIGNATURE was not anymore present for methods called after _buckaroo_generate_digital_sign.
For instance, the overriden method form_feedback of website_sale payment
  • Loading branch information
beledouxdenis committed Dec 19, 2014
1 parent c0dce6a commit 11f52c9
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions addons/payment_buckaroo/models/buckaroo.py
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,8 @@ def get_value(key):
return values[key]
return ''

values = dict(values or {})

if inout == 'out':
if 'BRQ_SIGNATURE' in values:
del values['BRQ_SIGNATURE']
Expand Down

0 comments on commit 11f52c9

Please sign in to comment.