Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gogensig: fix multiple fields with the same name #133

Closed
wants to merge 1 commit into from

Conversation

tsingbx
Copy link
Contributor

@tsingbx tsingbx commented Jan 7, 2025

No description provided.

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 38.29787% with 29 lines in your changes missing coverage. Please review.

Project coverage is 94.39%. Comparing base (0f12be8) to head (06abf22).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
cmd/gogensig/convert/type.go 20.58% 26 Missing and 1 partial ⚠️
cmd/gogensig/convert/names/names.go 84.61% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #133      +/-   ##
==========================================
- Coverage   98.12%   94.39%   -3.73%     
==========================================
  Files          17       18       +1     
  Lines        2132     2248     +116     
==========================================
+ Hits         2092     2122      +30     
- Misses         28      112      +84     
- Partials       12       14       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsingbx tsingbx changed the title gogensig: fix multiple fields with the same name [wip]gogensig: fix multiple fields with the same name Jan 7, 2025
@tsingbx tsingbx force-pushed the gogensig/uni_fields branch 4 times, most recently from a6fb9bc to 83309e4 Compare January 13, 2025 04:04
@tsingbx tsingbx closed this Jan 13, 2025
@tsingbx tsingbx force-pushed the gogensig/uni_fields branch from 83309e4 to 08d3a9b Compare January 13, 2025 04:09
@tsingbx tsingbx reopened this Jan 13, 2025
@tsingbx tsingbx force-pushed the gogensig/uni_fields branch from 4085f57 to e8f0f0e Compare January 13, 2025 04:14
@tsingbx tsingbx force-pushed the gogensig/uni_fields branch from e8f0f0e to 06abf22 Compare January 13, 2025 04:18
@tsingbx tsingbx changed the title [wip]gogensig: fix multiple fields with the same name gogensig: fix multiple fields with the same name Jan 13, 2025
@tsingbx tsingbx closed this Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant