Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llcppg:support split run symbol gen & code gen #142

Merged
merged 4 commits into from
Jan 13, 2025

Conversation

luoliwoshang
Copy link
Contributor

@luoliwoshang luoliwoshang commented Jan 8, 2025

llcppg -symbgen to only trigger llcppsymg to generate symbol table(llcppg.symb.json)
llcppg -codegen to only generate go binding (llcppsigfetch & gogensig)

llcppg [-vsymg|-vgogen|-vfetch] to control log for llcppsymg,llcppsigfetch,gogensig

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.12%. Comparing base (0f12be8) to head (0f1e8f6).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #142   +/-   ##
=======================================
  Coverage   98.12%   98.12%           
=======================================
  Files          17       17           
  Lines        2132     2132           
=======================================
  Hits         2092     2092           
  Misses         28       28           
  Partials       12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luoliwoshang luoliwoshang force-pushed the llcppg/singlerun branch 2 times, most recently from e9a08d1 to 718434e Compare January 9, 2025 02:29
llcppg.go Show resolved Hide resolved
@luoliwoshang luoliwoshang requested a review from tsingbx January 9, 2025 02:34
@luoliwoshang luoliwoshang force-pushed the llcppg/singlerun branch 2 times, most recently from 5cd34b7 to f95901e Compare January 9, 2025 08:09
if !codeGen {
err = llcppsymg(b)
check(err)
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议添加一个RunMode枚举

llcppg.go Outdated
go llcppsigfetch(b, w)
if !symbGen {
r, w := io.Pipe()
go llcppsigfetch(b, w)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

添加一个RunMode枚举

@tsingbx tsingbx merged commit 98b54cb into goplus:main Jan 13, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants