Support reads of binary data #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing code always turned on termChar, which results in problems when binary data is read since binary data may innocently contain termChar (defaulted to '\n'). A new method BulkRead unconditionally disables termChar. Added debugging information conditioned on an environment variable. Print sent and received headers. Allow the starting tag number to be overridden in the context. This may or may not be a useful change. Don't hard-code the initial buffer size. Read as much as the client wants to read, and then some.
If a short read, return the number of bytes read. If a complete read, return the transfer size, which may be smaller than the number of bytes read.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to make screenshots work for my Keysight scope, and decided to focus solely on the usbtmc layer. I made some changes to enable screenshots. This PR could easily be split into multiple commits, but I wanted to get a sniff test before going to all that effort. Please take a look and let me know what you think? Below is a rough list of the changes in the PR.