Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

put windowsevent stage in loki process doc back #2745

Merged
merged 11 commits into from
Feb 19, 2025
Merged

Conversation

wildum
Copy link
Contributor

@wildum wildum commented Feb 18, 2025

This was removed by mistake in #2594

Copy link
Contributor

github-actions bot commented Feb 18, 2025

💻 Deploy preview deleted.

Copy link
Contributor

@clayton-cornell clayton-cornell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh dear, that's embarrassing.

There's a couple more changes required....

After line 73, we need

| [`stage.windowsevent`][stage.windowsevent]        | Configures a `windowsevent` processing stage.                  | no       |

And after line 102 we need

[stage.windowsevent]: #stagewindowsevent

@wildum
Copy link
Contributor Author

wildum commented Feb 19, 2025

all done, thanks! I removed the backport labels because this stage is new, it will be released for the first time with 1.7

Copy link
Contributor

@thampiotr thampiotr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wildum wildum merged commit 0a8637d into main Feb 19, 2025
32 checks passed
@wildum wildum deleted the fix-windows-event-doc branch February 19, 2025 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants