Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add basic feature flags support #422

Merged
merged 3 commits into from
Jan 22, 2025
Merged

chore: Add basic feature flags support #422

merged 3 commits into from
Jan 22, 2025

Conversation

going-confetti
Copy link
Collaborator

@going-confetti going-confetti commented Jan 17, 2025 •
edited
Loading

Description

How to Test

  • Enter the "konami code" (up-up-down-down-left-right-left-right-b-a)
  • Toggle the data-files feature
  • Check that the Data files section is displayed in the sidebar
image

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (npm run lint) and all checks pass.
  • I have run tests locally (npm test) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Screenshots (if appropriate):

Related PR(s)/Issue(s)

allansson
allansson previously approved these changes Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@allansson allansson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried it out and it works like a charm. Left a comment on the code that might be worth considering.

src/components/DevToolsDialog.tsx Outdated Show resolved Hide resolved
@going-confetti going-confetti marked this pull request as ready for review January 17, 2025 16:08
@going-confetti going-confetti requested a review from a team as a code owner January 17, 2025 16:08
e-fisher
e-fisher approved these changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@e-fisher e-fisher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

cristianoventura
cristianoventura approved these changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@cristianoventura cristianoventura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🤩

@going-confetti going-confetti merged commit 1cf5139 into main Jan 22, 2025
3 checks passed
@going-confetti going-confetti deleted the chore/feature-flags-store branch January 22, 2025 09:27
This was referenced Jan 22, 2025
Merged
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@e-fisher e-fisher e-fisher approved these changes

@cristianoventura cristianoventura cristianoventura approved these changes

@allansson allansson allansson left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@going-confetti @allansson @cristianoventura @e-fisher