Fix G306 gosec issues #10380
Draft
Fix G306 gosec issues #10380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aknuds1
approved these changes
Jan 8, 2025
> G306: Expect WriteFile permissions to be 0600 or less The mimirtool commands should be ok. Makes using the tool a bit more restrictive, but linters gotta lint. My understanding of the AM changes is that they're safe too because the files written are only used immediately after that to validate them and never again, so they'll never be used by another user. But if would be nice if someone from AM-maintainers can pitch in Signed-off-by: Dimitar Dimitrov <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
…rst time ??? Signed-off-by: Dimitar Dimitrov <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
dimitarvdimitrov
force-pushed
the
dimitar/fix-G306
branch
from
ac3ff14 to
6fa1d48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
The mimirtool commands should be ok. Makes using the tool a bit more restrictive, but linters gotta lint.
My understanding of the AM changes is that they're safe too because the files written are only used immediately after that to validate them and never again, so they'll never be used by another user. But if would be nice if someone from @grafana/mimir-ruler-and-alertmanager-maintainers can pitch in
Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.