mixin : fix autoscaling panels #10473
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: AvivGuiser <[email protected]>
Signed-off-by: AvivGuiser <[email protected]>
Signed-off-by: AvivGuiser <[email protected]>
Signed-off-by: AvivGuiser <[email protected]>
pracucci
reviewed
Jan 20, 2025
There was a problem hiding this comment.
Unfortunately this may work with Helm installation, but not Mimir installed via jsonnet, because the latter doesn't have the mimir- part in the HPA resource names (e.g. it's keda-hpa-distributor and not keda-hpa-mimir-distributor). What we can do is to make the mimir- part optional in the regex, e.g. keda-hpa-(mimir-)?(.*).
Signed-off-by: AvivGuiser <[email protected]>
|
@pracucci i modified the PR according to what you said, is it ok ? |
dimitarvdimitrov
approved these changes
Jan 20, 2025
pracucci
reviewed
Jan 20, 2025
Co-authored-by: Marco Pracucci <[email protected]>
|
@pracucci commited your suggestion, thx! |
Signed-off-by: AvivGuiser <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
fix the autoscaling panels in the mixin dash to work with out of the box config
Which issue(s) this PR fixes or relates to
Fixes #9431
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.