-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace markblocks with rewritten mark-blocks #10597
base: main
Are you sure you want to change the base?
Conversation
💻 Deploy preview available: https://deploy-preview-mimir-10597-zb444pucvq-vp.a.run.app/docs/mimir/latest/ |
docs/internal/tools/mark-blocks.md
Outdated
@@ -0,0 +1,80 @@ | |||
# Mark blocks tool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Mark blocks tool | |
# Mark-blocks tool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this and the other suggestions! I committed most of them and percolated them out the changes to other tools READMEs for consistency. These titles seem tricky though. "Mark-blocks" strikes me as off because it's like a mixture of the actual tool name and a title but neither. I changed it to mark-blocks here and then mark-blocks
in the README. Does that seem okay?
Co-authored-by: Taylor C <[email protected]>
Co-authored-by: Taylor C <[email protected]>
What this PR does
This is still a work in progress. Documentation needs to be added and there are references toThis has been completed.markblocks
that need to be replaced.Replaces
markblocks
with a rewritten version uncreatively namedmark-blocks
.The motivation for this is that I'm in a situation (don't ask) that requires marking and then later unmarking a large number of blocks.
markblocks
as written was limiting for this because:The rewrite addresses these points.
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]
.about-versioning.md
updated with experimental features.