fix: increment error caching counter when trace not sampled #10631
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue introduced in #10537 where a counter was only incremented when a particular trace was sampled instead of always. Signed-off-by: Nick Pillitteri <[email protected]>
Signed-off-by: Nick Pillitteri <[email protected]>
julienduchesne
approved these changes
Feb 12, 2025
tacole02
reviewed
Feb 12, 2025
| @@ -51,7 +51,7 @@ | |||
| * [BUGFIX] Distributor: Use a boolean to track changes while merging the ReplicaDesc components, rather than comparing the objects directly. #10185 | |||
| * [BUGFIX] Querier: fix timeout responding to query-frontend when response size is very close to `-querier.frontend-client.grpc-max-send-msg-size`. #10154 | |||
| * [BUGFIX] Query-frontend and querier: show warning/info annotations in some cases where they were missing (if a lazy querier was used). #10277 | |||
| * [BUGFIX] Query-frontend: Fix an issue where transient errors could be inadvertently cached. #10537 | |||
| * [BUGFIX] Query-frontend: Fix an issue where transient errors could be inadvertently cached. #10537 #10631 | |||
There was a problem hiding this comment.
Suggested change
| * [BUGFIX] Query-frontend: Fix an issue where transient errors could be inadvertently cached. #10537 #10631 | |
| * [BUGFIX] Query-frontend: Fix an issue where transient errors are inadvertently cached. #10537 #10631 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Fixes an issue introduced in where a counter was only incremented when a particular trace was sampled instead of always.
Which issue(s) this PR fixes or relates to
Related #10537
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.