-
-
Notifications
You must be signed in to change notification settings - Fork 953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BootStrap init closure servletContext
cleanup
#13999
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure you update the functional tests that now live in grails core if they are passing the servletContext context to bootstrap.groovy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please be sure downstream changes get merged when this merges to minimize impact.
I cannot merge the PR by myself (I didnt find a way to do it), I've asked for a merge to all the following: |
Once views is merged, I'll merge this one. Can you please also confirm that grails-cache, grails-quartz, scaffolding, and fields don't need updates? |
@jdaugherty I can confirm I've found no |
@gsartori I think these are all merged. Please let me know if I missed anything. |
@jdaugherty it looks ok to me |
See: https://github.com/orgs/grails/discussions/13994