Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BootStrap init closure servletContext cleanup #13999

Merged
merged 4 commits into from
Feb 19, 2025
Merged

Conversation

gsartori
Copy link
Contributor

@gsartori gsartori commented Feb 5, 2025

Copy link
Contributor

@jdaugherty jdaugherty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure you update the functional tests that now live in grails core if they are passing the servletContext context to bootstrap.groovy.

Copy link
Contributor

@jdaugherty jdaugherty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please be sure downstream changes get merged when this merges to minimize impact.

@gsartori
Copy link
Contributor Author

@jdaugherty
Copy link
Contributor

Once views is merged, I'll merge this one. Can you please also confirm that grails-cache, grails-quartz, scaffolding, and fields don't need updates?

@gsartori
Copy link
Contributor Author

@jdaugherty I can confirm I've found no BootStrap.groovy files in the following repositories:

@jdaugherty jdaugherty merged commit cfa7157 into grails:7.0.x Feb 19, 2025
22 checks passed
@jdaugherty
Copy link
Contributor

@gsartori I think these are all merged. Please let me know if I missed anything.

@gsartori
Copy link
Contributor Author

@jdaugherty it looks ok to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants