use next/image again
#2163
Open
use next/image again
#2163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f `output: export`
|
@hasparus is attempting to deploy a commit to the The GraphQL Foundation Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR:
nextImageExportOptimizerdirectory with the rescaled images,next/imageinstead ofnext-image-export-optimizer,output: exportlqip-modern, butplaiceholderjust fits really well here and required very little code to integrate@saihaj I can't believe you and that one comment from Benjie in the WG issue got me to do this, but here it is.
This isn't just a refactor, because the new placeholder do in fact look better.
How to use the placeholders?
placeholder=blurwithblurDataURLwhenever you want something very smooth.blurDataURLexplicitly if thesrcisStaticImageDatafrom file import.plaiceholderwithgetStaticPropsinpagesand server components inappto get LQIPs for remote images.placeholder={data:image/${base64Placeholder}`} whenever you want something a bit pixelated. Normally I wouldn't but in some places it looks very appropriate with our design system.Disclaimer: This PR can be reverted if it turns out Vercel's Image Optimization API is prohibitively expensive.
Context
One historic reason for using
next-image-export-optimizercould have been the incompatibility ofnext/imagewithoutput: export. However, SSG in Next.js is no longer locked underoutput: export.