Remove the auth namespaces REST API #50999
Draft
+67
−650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosstimothy
force-pushed
the
tross/remove_namesapce_api
branch
3 times, most recently
from
1a35379 to
06c7e67
Compare
Eliminates the namespace CRUD API as part of #49509. The most notable change introduce here is with flushCache in the auth helpers. It was ironically using namespaces because they were deprecated, however, it has since been updated to use a role instead. The helpers.go file was also updated not to rely on testify in attempt to prevent it from being included in production builds. Updates #6394.
rosstimothy
force-pushed
the
tross/remove_namesapce_api
branch
from
06c7e67 to
8c01005
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminates the namespace CRUD API as part of #49509.
The most notable change introduce here is with flushCache in the auth helpers. It was ironically using namespaces because they were deprecated, however, it has since been updated to use a role instead. The helpers.go file was also updated not to rely on testify in attempt to prevent it from being included in production builds.