Skip to content

Commit

Permalink
rename webhooks to be clearly identifiable as from karmada
Browse files Browse the repository at this point in the history
Signed-off-by: Michael Grosser <[email protected]>
  • Loading branch information
grosser committed Jul 23, 2024
1 parent 721495d commit a0b5364
Show file tree
Hide file tree
Showing 5 changed files with 18 additions and 18 deletions.
8 changes: 4 additions & 4 deletions artifacts/deploy/webhook-configuration.yaml
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
apiVersion: admissionregistration.k8s.io/v1
kind: MutatingWebhookConfiguration
metadata:
name: mutating-config
name: karmada-mutations
labels:
app: mutating-config
app: karmada-webhook
webhooks:
- name: propagationpolicy.karmada.io
rules:
Expand Down Expand Up @@ -121,9 +121,9 @@ webhooks:
apiVersion: admissionregistration.k8s.io/v1
kind: ValidatingWebhookConfiguration
metadata:
name: validating-config
name: karmada-validations
labels:
app: validating-config
app: karmada-webhook
webhooks:
- name: propagationpolicy.karmada.io
rules:
Expand Down
8 changes: 4 additions & 4 deletions charts/karmada/templates/_karmada_webhook_configuration.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@
apiVersion: admissionregistration.k8s.io/v1
kind: MutatingWebhookConfiguration
metadata:
name: mutating-config
name: karmada-mutations
labels:
app: mutating-config
app: karmada-webhook
{{- include "karmada.commonLabels" . | nindent 4 }}
webhooks:
- name: propagationpolicy.karmada.io
Expand Down Expand Up @@ -126,9 +126,9 @@ webhooks:
apiVersion: admissionregistration.k8s.io/v1
kind: ValidatingWebhookConfiguration
metadata:
name: validating-config
name: karmada-validations
labels:
app: validating-config
app: karmada-webhook
{{- include "karmada.commonLabels" . | nindent 4 }}
webhooks:
- name: propagationpolicy.karmada.io
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@ const (
apiVersion: admissionregistration.k8s.io/v1
kind: MutatingWebhookConfiguration
metadata:
name: mutating-config
name: karmada-mutations
labels:
app: mutating-config
app: karmada-webhook
webhooks:
- name: propagationpolicy.karmada.io
rules:
Expand Down Expand Up @@ -145,9 +145,9 @@ webhooks:
apiVersion: admissionregistration.k8s.io/v1
kind: ValidatingWebhookConfiguration
metadata:
name: validating-config
name: karmada-validations
labels:
app: validating-config
app: karmada-webhook
webhooks:
- name: propagationpolicy.karmada.io
rules:
Expand Down
4 changes: 2 additions & 2 deletions pkg/karmadactl/cmdinit/karmada/deploy.go
Original file line number Diff line number Diff line change
Expand Up @@ -105,12 +105,12 @@ func InitKarmadaResources(dir, caBase64, systemNamespace string) error {

// create webhook configuration
// https://github.com/karmada-io/karmada/blob/master/artifacts/deploy/webhook-configuration.yaml
klog.Info("Create MutatingWebhookConfiguration mutating-config.")
klog.Info("Create MutatingWebhookConfiguration karmada-mutations.")
if err = createOrUpdateMutatingWebhookConfiguration(clientSet, mutatingConfig(caBase64, systemNamespace)); err != nil {
klog.Exitln(err)
}

klog.Info("Create ValidatingWebhookConfiguration validating-config.")
klog.Info("Create ValidatingWebhookConfiguration karmada-validations.")
if err = createOrUpdateValidatingWebhookConfiguration(clientSet, validatingConfig(caBase64, systemNamespace)); err != nil {
klog.Exitln(err)
}
Expand Down
8 changes: 4 additions & 4 deletions pkg/karmadactl/cmdinit/karmada/webhook_configuration.go
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,9 @@ func mutatingConfig(caBundle string, systemNamespace string) string {
return fmt.Sprintf(`apiVersion: admissionregistration.k8s.io/v1
kind: MutatingWebhookConfiguration
metadata:
name: mutating-config
name: karmada-mutations
labels:
app: mutating-config
app: karmada-webhook
webhooks:
- name: propagationpolicy.karmada.io
rules:
Expand Down Expand Up @@ -156,9 +156,9 @@ func validatingConfig(caBundle string, systemNamespace string) string {
return fmt.Sprintf(`apiVersion: admissionregistration.k8s.io/v1
kind: ValidatingWebhookConfiguration
metadata:
name: validating-config
name: karmada-validations
labels:
app: validating-config
app: karmada-webhook
webhooks:
- name: propagationpolicy.karmada.io
rules:
Expand Down

0 comments on commit a0b5364

Please sign in to comment.