Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update error-prone to 2.3.1 #4452

Closed
jyane opened this issue May 9, 2018 · 7 comments
Closed

Update error-prone to 2.3.1 #4452

jyane opened this issue May 9, 2018 · 7 comments
Milestone
1.17

Comments

@jyane
Copy link
Member

jyane commented May 9, 2018

https://github.com/google/error-prone/releases
@jyane jyane changed the title Update erorr-prone to 2.3.1 Update error-prone to 2.3.1 May 9, 2018
@jyane jyane mentioned this issue May 9, 2018
Closed
@jyane
Copy link
Member Author

jyane commented May 9, 2018

@ejona86 Are there any concerns?

@ejona86
Copy link
Member

ejona86 commented May 11, 2018

No concerns. I was hoping this would get done as well.

@carl-mastrangelo
Copy link
Contributor

I believe this drops support for DoNotMock, which we use.

@jyane
Copy link
Member Author

jyane commented May 14, 2018

I didn't noticed that drops support for DoNotMock...
google/error-prone#989
I don't know why it was removed, it seems to be internal problems.

@ejona86
Copy link
Member

ejona86 commented May 14, 2018

We spoke with them, and it was an accident it was ever exposed. Error-prone doesn't do anything with the annotation, so there's no point in it existing.

We can still update error_prone_core to pick up the new checks, even if we stay on an older version for annotations (and it seems we've already diverged there).

@ejona86 ejona86 added this to the Next milestone May 15, 2018
This was referenced Jul 19, 2018
Merged
Open
@ejona86 ejona86 self-assigned this Jul 19, 2018
@ejona86
Copy link
Member

ejona86 commented Jul 20, 2018

#4659 removed the @DoNotMocks, so this is now possible.

@ejona86 ejona86 removed their assignment Aug 9, 2018
@ejona86
Copy link
Member

ejona86 commented Dec 26, 2024

ErrorProne was upgraded to 2.3.2 in 183e1f6

@ejona86 ejona86 closed this as completed Dec 26, 2024
@ejona86 ejona86 modified the milestones: Next, 1.17 Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.17
Development

No branches or pull requests
3 participants
@ejona86 @jyane @carl-mastrangelo