Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

context: Avoid deprecated Truth API #4655

Merged
merged 1 commit into from
Jul 20, 2018
Merged

Conversation

ejona86
Copy link
Member

@ejona86 ejona86 commented Jul 18, 2018

This helps an internal cleanup removing the old failWithRawMessage API.

CC @carl-mastrangelo

This is cl/205457711 internally.

This helps an internal cleanup removing the old failWithRawMessage API.
Copy link
Member

@dapengzhang0 dapengzhang0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dapengzhang0
Copy link
Member

seems dependency on errorprone was also bumped...

@ejona86
Copy link
Member Author

ejona86 commented Jul 19, 2018

This is running into problems due to #4452

Truth is bumping the version of Guava and Guava is bumping the version of error_prone_annotations. Excluding dependencies isn't seeming to work for some reason.

@ejona86
Copy link
Member Author

ejona86 commented Jul 20, 2018

Uh, no GitHub, one PR can not "fix" another PR, such that it should be closed...

@ejona86 ejona86 reopened this Jul 20, 2018
@ejona86 ejona86 added the kokoro:force-run Add this label to a PR to tell Kokoro to re-run all tests. Not generally necessary label Jul 20, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to a PR to tell Kokoro to re-run all tests. Not generally necessary label Jul 20, 2018
@ejona86 ejona86 merged commit 6d7c7dc into grpc:master Jul 20, 2018
@ejona86 ejona86 deleted the failWithoutActual branch July 20, 2018 21:48
@lock lock bot locked as resolved and limited conversation to collaborators Oct 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants