Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

examples: Updated the reference attachHeaders to newAttachHeadersInterceptor in HeaderClientInterceptor #11759

Merged
merged 2 commits into from
Dec 24, 2024
Merged

examples: Updated the reference attachHeaders to newAttachHeadersInterceptor in HeaderClientInterceptor #11759

merged 2 commits into from
Dec 24, 2024

Conversation

vinodhabib
Copy link
Contributor

@vinodhabib vinodhabib commented Dec 17, 2024 •
edited
Loading

Updated the deleted reference attachHeaders to newAttachHeadersInterceptor in HeaderClientInterceptor for header example

Fixes #11693

@vinodhabib vinodhabib changed the title examples: Removed reference to deleted attachHeaders from HeaderClien… examples: Removed reference to deleted attachHeaders from HeaderClientInterceptor in header example Dec 17, 2024
@vinodhabib vinodhabib marked this pull request as ready for review December 18, 2024 11:46
shivaspeaks
shivaspeaks reviewed Dec 19, 2024
View reviewed changes
Copy link
Member

@shivaspeaks shivaspeaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any replacement for this deprecated method? Or is it totally removed?

This is what I found from the PR that removed the deprecated attachHeaders, Use {@code stub.withInterceptors(newAttachHeadersInterceptor(...))} instea
image

CC: @kannanjgithub

@vinodhabib
Copy link
Contributor Author

vinodhabib commented Dec 19, 2024 •
edited
Loading

Is there any replacement for this deprecated method? Or is it totally removed?

This is what I found from the PR that removed the deprecated attachHeaders, Use {@code stub.withInterceptors(newAttachHeadersInterceptor(...))} instea image

CC: @kannanjgithub

@shivaspeaks As per my understanding it looks like these deprecated methods are completely removed so this ticket is raised recently with the scope of removing the deleted reference of doc comments by label issue as docs.
also can see notes from Sanjay in the PR (#10443) as have made sure there is no internal usage of these methods

I hope we are good here, please confirm.

@shivaspeaks shivaspeaks requested a review from ejona86 December 20, 2024 10:19
@ejona86
Copy link
Member

ejona86 commented Dec 20, 2024

The reference should be updated to newAttachHeadersInterceptor()

@vinodhabib
Copy link
Contributor Author

vinodhabib commented Dec 23, 2024 •
edited
Loading

The reference should be updated to newAttachHeadersInterceptor()

@ejona86 Updated the same and Request you to do the needful.

@ejona86 ejona86 requested a review from shivaspeaks December 23, 2024 15:51
@shivaspeaks shivaspeaks added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Dec 24, 2024
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Dec 24, 2024
@vinodhabib vinodhabib changed the title examples: Removed reference to deleted attachHeaders from HeaderClientInterceptor in header example examples: Updated the deleted reference attachHeaders to newAttachHeadersInterceptor in HeaderClientInterceptor for header example Dec 24, 2024
@shivaspeaks shivaspeaks merged commit 5e8abc6 into grpc:master Dec 24, 2024
16 checks passed
@shivaspeaks shivaspeaks changed the title examples: Updated the deleted reference attachHeaders to newAttachHeadersInterceptor in HeaderClientInterceptor for header example examples: Updated the reference attachHeaders to newAttachHeadersInterceptor in HeaderClientInterceptor Dec 24, 2024
@vinodhabib vinodhabib deleted the defect-11693-remove-attachHeaders-doc branch December 26, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shivaspeaks shivaspeaks shivaspeaks approved these changes

@ejona86 ejona86 ejona86 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[examples] Remove reference to deleted attachHeaders from HeaderClientInterceptor
4 participants
@vinodhabib @ejona86 @shivaspeaks @grpc-kokoro