Skip to content

Commit

Permalink
use mysqldb in docker
Browse files Browse the repository at this point in the history
  • Loading branch information
binux committed May 27, 2015
1 parent bff5611 commit 41f55d7
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 7 deletions.
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ MAINTAINER binux <[email protected]>
# install python
RUN apt-get update && \
apt-get install -y python python-dev python-distribute python-pip && \
apt-get install -y libcurl4-openssl-dev libxml2-dev libxslt1-dev python-lxml
apt-get install -y libcurl4-openssl-dev libxml2-dev libxslt1-dev python-lxml python-mysqldb

# install requirements
ADD requirements.txt /opt/pyspider/requirements.txt
Expand Down
14 changes: 8 additions & 6 deletions pyspider/run.py
Original file line number Diff line number Diff line change
Expand Up @@ -95,13 +95,15 @@ def cli(ctx, **kwargs):
if kwargs[db] is not None:
continue
if os.environ.get('MYSQL_NAME'):
kwargs[db] = utils.Get(lambda db=db: connect_database('mysql+%s://%s:%s/%s' % (
db, os.environ['MYSQL_PORT_3306_TCP_ADDR'],
os.environ['MYSQL_PORT_3306_TCP_PORT'], db)))
kwargs[db] = utils.Get(lambda db=db: connect_database(
'sqlalchemy+mysql+%s://%s:%s/%s' % (
db, os.environ['MYSQL_PORT_3306_TCP_ADDR'],
os.environ['MYSQL_PORT_3306_TCP_PORT'], db)))
elif os.environ.get('MONGODB_NAME'):
kwargs[db] = utils.Get(lambda db=db: connect_database('mongodb+%s://%s:%s/%s' % (
db, os.environ['MONGODB_PORT_27017_TCP_ADDR'],
os.environ['MONGODB_PORT_27017_TCP_PORT'], db)))
kwargs[db] = utils.Get(lambda db=db: connect_database(
'mongodb+%s://%s:%s/%s' % (
db, os.environ['MONGODB_PORT_27017_TCP_ADDR'],
os.environ['MONGODB_PORT_27017_TCP_PORT'], db)))
elif ctx.invoked_subcommand == 'bench':
if kwargs['data_path'] == './data':
kwargs['data_path'] += '/bench'
Expand Down
1 change: 1 addition & 0 deletions tests/test_run.py
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,7 @@ def test_60_docker_mongodb(self):
del os.environ['MONGODB_PORT_27017_TCP_ADDR']
del os.environ['MONGODB_PORT_27017_TCP_PORT']

@unittest.skip('noly available in docker')
@unittest.skipIf(os.environ.get('IGNORE_MYSQL'), 'no mysql server for test.')
def test_70_docker_mysql(self):
try:
Expand Down

0 comments on commit 41f55d7

Please sign in to comment.