Skip to content

Commit

Permalink
crimson/os/seastore/../record_submitter: drop a duplicated metric
Browse files Browse the repository at this point in the history
The original "record group num" is identical to "io num".

Signed-off-by: Yingxin Cheng <[email protected]>
  • Loading branch information
cyx1231st committed May 30, 2024
1 parent c245900 commit f1e7ca6
Showing 1 changed file with 5 additions and 7 deletions.
12 changes: 5 additions & 7 deletions src/crimson/os/seastore/journal/record_submitter.cc
Original file line number Diff line number Diff line change
Expand Up @@ -293,6 +293,8 @@ RecordSubmitter::submit(
auto block_size = journal_allocator.get_block_size();
auto rg = record_group_t(std::move(record), block_size);
account_submission(rg);
assert(stats.record_batch_stats.num_io ==
stats.io_depth_stats.num_io);
record_group_size_t sizes = rg.size;
auto to_write = p_current_batch->submit_pending_fast(
std::move(rg),
Expand Down Expand Up @@ -370,14 +372,8 @@ RecordSubmitter::open(bool is_mkfs)
{
sm::make_counter(
"record_num",
stats.record_batch_stats.num_io,
sm::description("total number of records submitted"),
label_instances
),
sm::make_counter(
"record_batch_num",
stats.record_batch_stats.num_io_grouped,
sm::description("total number of records batched"),
sm::description("total number of records submitted"),
label_instances
),
sm::make_counter(
Expand Down Expand Up @@ -512,6 +508,8 @@ void RecordSubmitter::flush_current_batch()
assert(rg.get_size() == num);
record_group_size_t sizes = rg.size;
account_submission(rg);
assert(stats.record_batch_stats.num_io ==
stats.io_depth_stats.num_io);
auto to_write = p_batch->encode_batch(
get_committed_to(), journal_allocator.get_nonce());
// Note: rg is cleared
Expand Down

0 comments on commit f1e7ca6

Please sign in to comment.