Skip to content

Commit

Permalink
remove honcho in the dev environment (just use foregrounded supervisor)
Browse files Browse the repository at this point in the history
using supervisor gives us the ability to restart entire processes on
code change (like the dispatcher and callback receiver)
  • Loading branch information
ryanpetrello committed May 8, 2019
1 parent 70972f7 commit 766a5c0
Show file tree
Hide file tree
Showing 7 changed files with 9 additions and 31 deletions.
12 changes: 2 additions & 10 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -269,15 +269,7 @@ supervisor:
@if [ "$(VENV_BASE)" ]; then \
. $(VENV_BASE)/awx/bin/activate; \
fi; \
supervisord --pidfile=/tmp/supervisor_pid

# Alternate approach to tmux to run all development tasks specified in
# Procfile.
honcho:
@if [ "$(VENV_BASE)" ]; then \
. $(VENV_BASE)/awx/bin/activate; \
fi; \
honcho start -f tools/docker-compose/Procfile
supervisord --pidfile=/tmp/supervisor_pid -n

collectstatic:
@if [ "$(VENV_BASE)" ]; then \
Expand All @@ -289,7 +281,7 @@ uwsgi: collectstatic
@if [ "$(VENV_BASE)" ]; then \
. $(VENV_BASE)/awx/bin/activate; \
fi; \
uwsgi -b 32768 --socket 127.0.0.1:8050 --module=awx.wsgi:application --home=/venv/awx --chdir=/awx_devel/ --vacuum --processes=5 --harakiri=120 --master --no-orphans --py-autoreload 1 --max-requests=1000 --stats /tmp/stats.socket --lazy-apps --logformat "%(addr) %(method) %(uri) - %(proto) %(status)" --hook-accepting1="exec:awx-manage run_dispatcher --reload"
uwsgi -b 32768 --socket 127.0.0.1:8050 --module=awx.wsgi:application --home=/venv/awx --chdir=/awx_devel/ --vacuum --processes=5 --harakiri=120 --master --no-orphans --py-autoreload 1 --max-requests=1000 --stats /tmp/stats.socket --lazy-apps --logformat "%(addr) %(method) %(uri) - %(proto) %(status)" --hook-accepting1="exec:supervisorctl restart tower-processes:awx-dispatcher tower-processes:awx-receiver"

daphne:
@if [ "$(VENV_BASE)" ]; then \
Expand Down
1 change: 0 additions & 1 deletion docs/websockets.md
Original file line number Diff line number Diff line change
Expand Up @@ -64,4 +64,3 @@ by the *daphne* server and our *asgi_amqp* implementation to broadcast messages

### Development
- nginx listens on 8013/8043 instead of 80/443
- uwsgi, daphne, and runworker are started with honcho instead of supervisord
7 changes: 1 addition & 6 deletions tools/clusterdevel/bootstrap_minishift.sh
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,4 @@ mkdir -p /awx_devel/awx/public/static
mkdir -p /awx_devel/awx/ui/static

cd /awx_devel
# Start the services
if [ -f "/awx_devel/tools/docker-compose/use_dev_supervisor.txt" ]; then
make supervisor
else
honcho start -f "tools/docker-compose/Procfile"
fi
make supervisor
2 changes: 1 addition & 1 deletion tools/docker-compose/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ RUN python3 -m ensurepip
RUN pip3 install virtualenv
RUN /usr/bin/ssh-keygen -q -t rsa -N "" -f /root/.ssh/id_rsa
RUN mkdir -p /data/db
RUN pip3 install honcho && pip install supervisor
RUN pip install supervisor

ADD requirements/requirements.txt \
requirements/requirements_git.txt \
Expand Down
7 changes: 0 additions & 7 deletions tools/docker-compose/Procfile

This file was deleted.

7 changes: 1 addition & 6 deletions tools/docker-compose/start_development.sh
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,4 @@ set +x

cd /awx_devel
# Start the services
if [ -f "/awx_devel/tools/docker-compose/use_dev_supervisor.txt" ]; then
make supervisor
else
export PYTHONIOENCODING=utf_8
honcho start -f "tools/docker-compose/Procfile"
fi
make supervisor
4 changes: 4 additions & 0 deletions tools/docker-compose/supervisor.conf
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,10 @@ command = make uwsgi
autostart = true
autorestart = true
redirect_stderr=true
stopwaitsecs = 1
stopsignal=KILL
stopasgroup=true
killasgroup=true
stdout_logfile=/dev/fd/1
stdout_logfile_maxbytes=0

Expand Down

0 comments on commit 766a5c0

Please sign in to comment.