Added saved_albums methods on User for (undocumented) me/albums endpoints #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # @example | ||
| # albums = user.saved_albums | ||
| # albums.size #=> 20 | ||
| # albums.first.name #=> "Do I Wanna Know?" |
There was a problem hiding this comment.
"Do I Wanna Know?" was for the track so you can replace this for any album name you like :)
|
This looks great, thanks for that =) I don't see in Spotify Terms anything saying undocumented endpoints can't be accessed, so this should be good to go. Can you just check some minor comments I made in the code and squash them into your commit? Thanks again for finding this out! |
…ints Album endpoints minor edits
tony-pizza
force-pushed
the
library-albums
branch
from
7fb7bbe to
74a4151
Compare
|
Awesome! I made those changes, and added a bit to the README. |
|
That's awesome 👍 thanks, shipping it |
guilhermesad
added a commit
that referenced
this pull request
Nov 22, 2015
Added saved_albums methods on User for (undocumented) me/albums endpoints
|
What do ya know... these endpoints are now documented: https://developer.spotify.com/web-api/library-endpoints/ |
|
lol wow, maybe they noticed the amount of traffic after this was merged xD |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the Spotify API has library endpoints for albums, and so I added support for them. They're basically identical to the
me/trackslibrary endpoints, except you know, for albums:me/albums.One big benefit here is when you save albums to your library via
me/albumsthose albums show up in the "Saved Albums Only" filter, which isn't possible when usingme/tracks.The problem is... the album endpoints are undocumented. I only found them because I was poking around. So I totally understand if this doesn't get merged. Might be against Spotify Terms to use undocumented pieces of their API. Still, figured I'd PR, if only to say hey this exists. And if they ever go public with the album endpoints, we'll be ready...