Skip to content

Tags: guolinke/pytorch

Tags

v1.8.1

Toggle v1.8.1's commit message

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Perform appropriate CUDA stream synchronization in distributed autogr…

…ad. (pytorch#53929) (pytorch#54358)

Summary:
Pull Request resolved: pytorch#53929

The local autograd engine performs appropriate stream synchronization
between autograd nodes in the graph to ensure a consumer's stream is
synchronized with the producer's stream before executing the consumer.

However in case of distributed autograd, the SendRpcBackward function receives
gradients over the wire and TensorPipe uses its own pool of streams for this
purpose. As a result, the tensors are received on TensorPipe's stream pool but
SendRpcBackward runs on a different stream during the backward pass and there
is no logic to synchronize these streams.

To fix this, I've enhanced DistEngine to synchronize these streams
appropriately when it receives grads over the wire.
ghstack-source-id: 124055277

(Note: this ignores all push blocking failures!)

Test Plan:
1) Added unit test which reproduced the issue.
2) waitforbuildbot.

Reviewed By: walterddr, wanchaol

Differential Revision: D27025307

fbshipit-source-id: 2944854e688e001cb3989d2741727b30d9278414

Co-authored-by: Pritam Damania <[email protected]>

v1.8.1-rc3

Toggle v1.8.1-rc3's commit message

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Perform appropriate CUDA stream synchronization in distributed autogr…

…ad. (pytorch#53929) (pytorch#54358)

Summary:
Pull Request resolved: pytorch#53929

The local autograd engine performs appropriate stream synchronization
between autograd nodes in the graph to ensure a consumer's stream is
synchronized with the producer's stream before executing the consumer.

However in case of distributed autograd, the SendRpcBackward function receives
gradients over the wire and TensorPipe uses its own pool of streams for this
purpose. As a result, the tensors are received on TensorPipe's stream pool but
SendRpcBackward runs on a different stream during the backward pass and there
is no logic to synchronize these streams.

To fix this, I've enhanced DistEngine to synchronize these streams
appropriately when it receives grads over the wire.
ghstack-source-id: 124055277

(Note: this ignores all push blocking failures!)

Test Plan:
1) Added unit test which reproduced the issue.
2) waitforbuildbot.

Reviewed By: walterddr, wanchaol

Differential Revision: D27025307

fbshipit-source-id: 2944854e688e001cb3989d2741727b30d9278414

Co-authored-by: Pritam Damania <[email protected]>

v1.8.1-rc2

Toggle v1.8.1-rc2's commit message

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
third_party: Update kineto to fix libtorch builds (pytorch#54205)

Signed-off-by: Eli Uriegas <[email protected]>

v1.8.1-rc1

Toggle v1.8.1-rc1's commit message

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
third_party: Update kineto to fix libtorch builds (pytorch#54205)

Signed-off-by: Eli Uriegas <[email protected]>

v1.8.0

Toggle v1.8.0's commit message

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Fix hipify_python (pytorch#52756)

Co-authored-by: rraminen <[email protected]>
Co-authored-by: Nikita Shulga <[email protected]>

v1.8.0-rc5

Toggle v1.8.0-rc5's commit message

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Fix hipify_python (pytorch#52756)

Co-authored-by: rraminen <[email protected]>
Co-authored-by: Nikita Shulga <[email protected]>

v1.8.0-rc4

Toggle v1.8.0-rc4's commit message

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
apply diff 52351 (pytorch#52649)

v1.8.0-rc3

Toggle v1.8.0-rc3's commit message

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
[1.8] Fix onnx mixed precision export for layernorm & fuseLogSoftmaxN…

…llLoss (pytorch#52510)

Co-authored-by: Shubham Bhokare <[email protected]>

v1.8.0-rc2

Toggle v1.8.0-rc2's commit message

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
[v1.8 patch] [Resubmission] Add a documentation page for DDP communic…

…ation hooks (pytorch#52215)

Co-authored-by: wayi <[email protected]>

v1.8.0-rc1

Toggle v1.8.0-rc1's commit message
[FX][docs] Indent forward (pytorch#51802)

Summary:
Pull Request resolved: pytorch#51802

lol

Test Plan: Imported from OSS

Reviewed By: zou3519

Differential Revision: D26284311

Pulled By: jamesr66a

fbshipit-source-id: 0d303d8c99131abb8d97e0acd0ac2d810e1e950c