Re-add haste modules for ReactTypes and ReactNativeRTTypes shims (fac…

…ebook#11557) * Re-add haste module for ReactNativeRTTypes * Re-added ReactTypes @providesModule annotation as well * Updated expected provides modules list * Improved clarity of check_modules.sh error message * Added ReactTypes to provides module whitelist
guotie · Nov 15, 2017 · 3322f6b · 3322f6b
1 parent 634b70a
commit 3322f6b
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 1 deletion.
diff --git a/packages/react-rt-renderer/src/ReactNativeRTTypes.js b/packages/react-rt-renderer/src/ReactNativeRTTypes.js
@@ -5,6 +5,7 @@
  * LICENSE file in the root directory of this source tree.
  *
  * @flow
+ * @providesModule ReactNativeRTTypes
  */
 
 /**

diff --git a/packages/shared/ReactTypes.js b/packages/shared/ReactTypes.js
@@ -5,6 +5,7 @@
  * LICENSE file in the root directory of this source tree.
  *
  * @flow
+ * @providesModule ReactTypes
  */
 
 export type ReactNode =

diff --git a/scripts/circleci/check_modules.sh b/scripts/circleci/check_modules.sh
@@ -5,11 +5,17 @@ set -e
 # Make sure we don't introduce accidental @providesModule annotations.
 EXPECTED='packages/react-cs-renderer/src/ReactNativeCSTypes.js
 packages/react-native-renderer/src/ReactNativeTypes.js
+packages/react-rt-renderer/src/ReactNativeRTTypes.js
+packages/shared/ReactTypes.js
 scripts/rollup/wrappers.js'
 ACTUAL=$(git grep -l @providesModule -- './*.js' ':!scripts/rollup/shims/*.js')
 
+# Colors
+red=$'\e[1;31m'
+end=$'\e[0m'
+
 if [ "$EXPECTED" != "$ACTUAL" ]; then
-  echo "@providesModule crept into some new files?"
+  printf "%s\n" "${red}ERROR: @providesModule crept into some new files?${end}"
   diff -u <(echo "$EXPECTED") <(echo "$ACTUAL") || true
   exit 1
 fi
-Original file line number
+Diff line change
@@ Expand Up / @@ -5,6 +5,7 @@ @@
      * LICENSE file in the root directory of this source tree.
      *
      * @flow
+     * @providesModule ReactNativeRTTypes
      */
     /**
@@ Expand Down @@