Automatically create database if it doesn't exist #24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Meltano, I like to namespace each extractor to a new database to avoid conflicts (like
tap-github
andtap-shopify
both havingusers
tables) by setting the database name dynamically:However this means the database needs to exist before the tap can be run.
This change runs
CREATE DATABASE IF NOT EXISTS
before uploading.Because meltano/sdk#246 hasn't been implemented, there's not a clean place to put a setup step to run once before the whole target run. Instead this will run for each sink in the constructor, which is not ideal but it should be fine.