fix exception when resizing removes video embed

halo2404 · Nov 26, 2024 · 311b472 · 311b472
1 parent 1f8484d
commit 311b472
Showing 1 changed file with 11 additions and 11 deletions.
diff --git a/ui/analyse/src/study/relay/videoPlayer.ts b/ui/analyse/src/study/relay/videoPlayer.ts
@@ -47,19 +47,19 @@ export class VideoPlayer {
     if (this.animationFrameId) {
       cancelAnimationFrame(this.animationFrameId);
     }
-    if (!el) {
-      if (!document.body.contains(this.iframe)) return;
-      document.body.removeChild(this.iframe);
-      document.body.removeChild(this.close);
-    }
     this.animationFrameId = requestAnimationFrame(() => {
+      if (!el) {
+        this.iframe.remove();
+        this.close.remove();
+        return;
+      }
       this.iframe.style.display = 'block';
-      this.iframe.style.left = `${el!.offsetLeft}px`;
-      this.iframe.style.top = `${el!.offsetTop}px`;
-      this.iframe.style.width = `${el!.offsetWidth}px`;
-      this.iframe.style.height = `${el!.offsetHeight}px`;
-      this.close.style.left = `${el!.offsetLeft + el!.offsetWidth - 16}px`;
-      this.close.style.top = `${el!.offsetTop - 4}px`;
+      this.iframe.style.left = `${el.offsetLeft}px`;
+      this.iframe.style.top = `${el.offsetTop}px`;
+      this.iframe.style.width = `${el.offsetWidth}px`;
+      this.iframe.style.height = `${el.offsetHeight}px`;
+      this.close.style.left = `${el.offsetLeft + el!.offsetWidth - 16}px`;
+      this.close.style.top = `${el.offsetTop - 4}px`;
       if (document.body.contains(this.iframe)) return;
       document.body.appendChild(this.iframe);
       document.body.appendChild(this.close);