Skip to content

Commit

Permalink
eutils.eclass: Deprecate validate_desktop_entries
Browse files Browse the repository at this point in the history
The validate_desktop_entries function is redundant to the built-in
.desktop file checks done by Portage directly. It is used in total by
two packages for both of which bugs have been filed.
  • Loading branch information
mgorny committed Mar 18, 2017
1 parent 7166702 commit 650a1eb
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion eclass/eutils.eclass
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright 1999-2015 Gentoo Foundation
# Copyright 1999-2017 Gentoo Foundation
# Distributed under the terms of the GNU General Public License v2

# @ECLASS: eutils.eclass
Expand Down Expand Up @@ -883,6 +883,9 @@ _eutils_eprefix_init() {
# @DESCRIPTION:
# Validate desktop entries using desktop-file-utils
validate_desktop_entries() {
eqawarn "validate_desktop_entries is deprecated and should be not be used."
eqawarn ".desktop file validation is done implicitly by Portage now."

_eutils_eprefix_init
if [[ -x "${EPREFIX}"/usr/bin/desktop-file-validate ]] ; then
einfo "Checking desktop entry validity"
Expand Down

0 comments on commit 650a1eb

Please sign in to comment.