Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include webpack static files. #43

Merged
merged 1 commit into from
Aug 23, 2018

Conversation

joaovieira
Copy link
Contributor

@joaovieira joaovieira commented Aug 23, 2018

  • Include webpack generated static files (e.g. .next/static/commons/main.js, .next/static/style.css)
  • Better formatting of precache array (indented)
  • Refactor

However, I believe there's a better way of doing this as the workbox generated precache manifest contains all the Next.js emitted assets. We should be reading that file, looping through all of those files and simply remapping the url with the new buildId revision.

Any reason why we shouldn't do that? If you agree I can do it.

@hanford
Copy link
Owner

hanford commented Aug 23, 2018

I think what you're describing would be great!

@joaovieira
Copy link
Contributor Author

Cool 👍 You can still merge this if you want as it's doing its job and I'll open another PR tomorrow off of master.

@hanford hanford merged commit 97991c8 into hanford:master Aug 23, 2018
@joaovieira
Copy link
Contributor Author

Won't be doing what I mentioned just now - there's more manual steps than previously thought. I created #49 to do that later.

Could you release a new version with this PR?

Thanks!

@hanford
Copy link
Owner

hanford commented Aug 24, 2018

live in 2.11.0

thanks for the contributions over the last couple of days 😍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants