Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One sample includes all #1

Open
wants to merge 432 commits into
base: master
Choose a base branch
from
Open

One sample includes all #1

wants to merge 432 commits into from

Conversation

hannesa2
Copy link
Owner

@hannesa2 hannesa2 commented Jul 13, 2020

With one main sample app and include all others as modules it's easier to maintain, see what's included and verify on CI

@hannesa2 hannesa2 force-pushed the OneSample branch 7 times, most recently from e9fbf77 to c64c242 Compare July 18, 2020 09:21
@hannesa2 hannesa2 changed the title One sample One sample includes all Jul 18, 2020
@thatfiredev
Copy link

thatfiredev commented Jul 18, 2020

@hannesa2 I particularly prefer the way they are right now (separate modules), this way developers can build each module separately, since sometimes they're only interested in trying out only one of the apps.

On a side note, I think it would be cool if you listed on the PR description all the tools you've included on CI (e.g protobot/stale). Because some of those tools might require permissions that the organization (Google in this case) is not willing to grant.

@hannesa2 hannesa2 force-pushed the OneSample branch 3 times, most recently from f045e9a to bfd54d5 Compare July 19, 2020 05:25
@hannesa2
Copy link
Owner Author

@hannesa2 I particularly prefer the way they are right now (separate modules), this way developers can build each module separately, since sometimes they're only interested in trying out only one of the apps.

Yes, and every developer don't know, what the other does.
Separate apps will need a separate CI task, which are not done

On a side note, I think it would be cool if you listed on the PR description all the tools you've included on CI (e.g protobot/stale). Because some of those tools might require permissions that the organization (Google in this case) is not willing to grant.

Don't worry, as long as nobody likes this practical all-in-one sample, this CI changes will be never a pull request in upstream repo (look it's a PR into my fork)

@hannesa2
Copy link
Owner Author

For me at least it makes sense. Now, I've an overview what's included.
@rosariopfernandes
Please remember, you make your upstream repo for other developer, not for you !

image

@hannesa2 hannesa2 force-pushed the OneSample branch 4 times, most recently from acadc00 to 01b4678 Compare July 19, 2020 10:36
@thatfiredev
Copy link

@hannesa2 Oops, I didn't notice this was on your fork, my bad. I got here through a comment you left on a PR to the upstream repo. Thanks for pointing that out!

@hannesa2
Copy link
Owner Author

@rosariopfernandes
Please mention, now there is a CI which tests ALL android projects

image

@hannesa2
Copy link
Owner Author

This is how it looks like

image

@hannesa2 hannesa2 force-pushed the OneSample branch 2 times, most recently from e04a1fb to 5be4954 Compare July 27, 2020 04:59
@hannesa2 hannesa2 force-pushed the OneSample branch 2 times, most recently from 71353bc to 99d8e8a Compare July 29, 2020 09:05
dependabot bot and others added 30 commits November 22, 2024 13:01
Bumps androidx.constraintlayout:constraintlayout from 2.1.4 to 2.2.0.

---
updated-dependencies:
- dependency-name: androidx.constraintlayout:constraintlayout
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
…mple/androidx.constraintlayout-constraintlayout-2.2.0

Bump androidx.constraintlayout:constraintlayout from 2.1.4 to 2.2.0 in /android
Bumps androidx.core:core-ktx from 1.13.1 to 1.15.0.

---
updated-dependencies:
- dependency-name: androidx.core:core-ktx
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
…/android

Dependabot couldn't find the original pull request head commit, fccbc43.
…mple/com.google.firebase-firebase-analytics-22.1.2

Bump com.google.firebase:firebase-analytics from 21.0.0 to 22.1.2 in /android
…mple/androidx.core-core-ktx-1.15.0

Bump androidx.core:core-ktx from 1.13.1 to 1.15.0 in /android
Bumps com.google.android.gms:play-services-mlkit-text-recognition from 18.0.2 to 19.0.1.

---
updated-dependencies:
- dependency-name: com.google.android.gms:play-services-mlkit-text-recognition
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps androidx.test.ext:junit from 1.1.3 to 1.2.1.

---
updated-dependencies:
- dependency-name: androidx.test.ext:junit
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [com.google.android.material:material](https://github.com/material-components/material-components-android) from 1.5.0 to 1.12.0.
- [Release notes](https://github.com/material-components/material-components-android/releases)
- [Commits](material-components/material-components-android@1.5.0...1.12.0)

---
updated-dependencies:
- dependency-name: com.google.android.material:material
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
…mple/com.google.android.gms-play-services-mlkit-text-recognition-19.0.1

Bump com.google.android.gms:play-services-mlkit-text-recognition from 18.0.2 to 19.0.1 in /android
…mple/androidx.test.ext-junit-1.2.1

Bump androidx.test.ext:junit from 1.1.3 to 1.2.1 in /android
…mple/com.google.android.material-material-1.12.0

Bump com.google.android.material:material from 1.5.0 to 1.12.0 in /android
Bumps androidx.test:runner from 1.4.0 to 1.6.2.

---
updated-dependencies:
- dependency-name: androidx.test:runner
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps com.google.firebase:firebase-crashlytics-gradle from 2.9.9 to 3.0.2.

---
updated-dependencies:
- dependency-name: com.google.firebase:firebase-crashlytics-gradle
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps androidx.exifinterface:exifinterface from 1.3.6 to 1.3.7.

---
updated-dependencies:
- dependency-name: androidx.exifinterface:exifinterface
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
…mple/androidx.exifinterface-exifinterface-1.3.7

Bump androidx.exifinterface:exifinterface from 1.3.6 to 1.3.7 in /android
…mple/androidx.test-runner-1.6.2

Bump androidx.test:runner from 1.4.0 to 1.6.2 in /android
…mple/com.google.firebase-firebase-crashlytics-gradle-3.0.2

Bump com.google.firebase:firebase-crashlytics-gradle from 2.9.9 to 3.0.2 in /android
Bumps androidx.lifecycle:lifecycle-viewmodel-ktx from 2.5.1 to 2.8.7.

---
updated-dependencies:
- dependency-name: androidx.lifecycle:lifecycle-viewmodel-ktx
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps `kotlin_version` from 2.0.21 to 2.1.0.

Updates `org.jetbrains.kotlin:kotlin-gradle-plugin` from 2.0.21 to 2.1.0
- [Release notes](https://github.com/JetBrains/kotlin/releases)
- [Changelog](https://github.com/JetBrains/kotlin/blob/master/ChangeLog.md)
- [Commits](https://github.com/JetBrains/kotlin/commits)

Updates `org.jetbrains.kotlin:kotlin-stdlib-jdk7` from 2.0.21 to 2.1.0
- [Release notes](https://github.com/JetBrains/kotlin/releases)
- [Changelog](https://github.com/JetBrains/kotlin/blob/master/ChangeLog.md)
- [Commits](https://github.com/JetBrains/kotlin/commits)

---
updated-dependencies:
- dependency-name: org.jetbrains.kotlin:kotlin-gradle-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: org.jetbrains.kotlin:kotlin-stdlib-jdk7
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
…mple/androidx.lifecycle-lifecycle-viewmodel-ktx-2.8.7

Bump androidx.lifecycle:lifecycle-viewmodel-ktx from 2.5.1 to 2.8.7 in /android
…mple/kotlin_version-2.1.0

Bump kotlin_version from 2.0.21 to 2.1.0 in /android
Bumps [com.google.firebase:firebase-crashlytics](https://github.com/firebase/firebase-android-sdk) from 19.0.0 to 19.2.1.
- [Commits](https://github.com/firebase/firebase-android-sdk/commits)

---
updated-dependencies:
- dependency-name: com.google.firebase:firebase-crashlytics
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps androidx.appcompat:appcompat from 1.6.0 to 1.7.0.

---
updated-dependencies:
- dependency-name: androidx.appcompat:appcompat
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
…mple/androidx.appcompat-appcompat-1.7.0

Bump androidx.appcompat:appcompat from 1.6.0 to 1.7.0 in /android
…mple/com.google.firebase-firebase-crashlytics-19.2.1

Bump com.google.firebase:firebase-crashlytics from 19.0.0 to 19.2.1 in /android
Bumps [com.google.auto.value:auto-value-annotations](https://github.com/google/auto) from 1.10.1 to 1.11.0.
- [Release notes](https://github.com/google/auto/releases)
- [Commits](google/auto@auto-value-1.10.1...auto-value-1.11.0)

---
updated-dependencies:
- dependency-name: com.google.auto.value:auto-value-annotations
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
…mple/com.google.auto.value-auto-value-annotations-1.11.0

Bump com.google.auto.value:auto-value-annotations from 1.10.1 to 1.11.0 in /android
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants