-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
One sample includes all #1
base: master
Are you sure you want to change the base?
Conversation
e9fbf77
to
c64c242
Compare
@hannesa2 I particularly prefer the way they are right now (separate modules), this way developers can build each module separately, since sometimes they're only interested in trying out only one of the apps. On a side note, I think it would be cool if you listed on the PR description all the tools you've included on CI (e.g protobot/stale). Because some of those tools might require permissions that the organization (Google in this case) is not willing to grant. |
f045e9a
to
bfd54d5
Compare
Yes, and every developer don't know, what the other does.
Don't worry, as long as nobody likes this practical all-in-one sample, this CI changes will be never a pull request in upstream repo (look it's a PR into my fork) |
For me at least it makes sense. Now, I've an overview what's included. |
acadc00
to
01b4678
Compare
@hannesa2 Oops, I didn't notice this was on your fork, my bad. I got here through a comment you left on a PR to the upstream repo. Thanks for pointing that out! |
@rosariopfernandes |
e04a1fb
to
5be4954
Compare
71353bc
to
99d8e8a
Compare
Bumps androidx.constraintlayout:constraintlayout from 2.1.4 to 2.2.0. --- updated-dependencies: - dependency-name: androidx.constraintlayout:constraintlayout dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
…mple/androidx.constraintlayout-constraintlayout-2.2.0 Bump androidx.constraintlayout:constraintlayout from 2.1.4 to 2.2.0 in /android
Bumps androidx.core:core-ktx from 1.13.1 to 1.15.0. --- updated-dependencies: - dependency-name: androidx.core:core-ktx dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
…/android Dependabot couldn't find the original pull request head commit, fccbc43.
…mple/com.google.firebase-firebase-analytics-22.1.2 Bump com.google.firebase:firebase-analytics from 21.0.0 to 22.1.2 in /android
…mple/androidx.core-core-ktx-1.15.0 Bump androidx.core:core-ktx from 1.13.1 to 1.15.0 in /android
Bumps com.google.android.gms:play-services-mlkit-text-recognition from 18.0.2 to 19.0.1. --- updated-dependencies: - dependency-name: com.google.android.gms:play-services-mlkit-text-recognition dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps androidx.test.ext:junit from 1.1.3 to 1.2.1. --- updated-dependencies: - dependency-name: androidx.test.ext:junit dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [com.google.android.material:material](https://github.com/material-components/material-components-android) from 1.5.0 to 1.12.0. - [Release notes](https://github.com/material-components/material-components-android/releases) - [Commits](material-components/material-components-android@1.5.0...1.12.0) --- updated-dependencies: - dependency-name: com.google.android.material:material dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
…mple/com.google.android.gms-play-services-mlkit-text-recognition-19.0.1 Bump com.google.android.gms:play-services-mlkit-text-recognition from 18.0.2 to 19.0.1 in /android
…mple/androidx.test.ext-junit-1.2.1 Bump androidx.test.ext:junit from 1.1.3 to 1.2.1 in /android
…mple/com.google.android.material-material-1.12.0 Bump com.google.android.material:material from 1.5.0 to 1.12.0 in /android
Bumps androidx.test:runner from 1.4.0 to 1.6.2. --- updated-dependencies: - dependency-name: androidx.test:runner dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps com.google.firebase:firebase-crashlytics-gradle from 2.9.9 to 3.0.2. --- updated-dependencies: - dependency-name: com.google.firebase:firebase-crashlytics-gradle dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps androidx.exifinterface:exifinterface from 1.3.6 to 1.3.7. --- updated-dependencies: - dependency-name: androidx.exifinterface:exifinterface dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
…mple/androidx.exifinterface-exifinterface-1.3.7 Bump androidx.exifinterface:exifinterface from 1.3.6 to 1.3.7 in /android
…mple/androidx.test-runner-1.6.2 Bump androidx.test:runner from 1.4.0 to 1.6.2 in /android
…mple/com.google.firebase-firebase-crashlytics-gradle-3.0.2 Bump com.google.firebase:firebase-crashlytics-gradle from 2.9.9 to 3.0.2 in /android
Bumps androidx.lifecycle:lifecycle-viewmodel-ktx from 2.5.1 to 2.8.7. --- updated-dependencies: - dependency-name: androidx.lifecycle:lifecycle-viewmodel-ktx dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps `kotlin_version` from 2.0.21 to 2.1.0. Updates `org.jetbrains.kotlin:kotlin-gradle-plugin` from 2.0.21 to 2.1.0 - [Release notes](https://github.com/JetBrains/kotlin/releases) - [Changelog](https://github.com/JetBrains/kotlin/blob/master/ChangeLog.md) - [Commits](https://github.com/JetBrains/kotlin/commits) Updates `org.jetbrains.kotlin:kotlin-stdlib-jdk7` from 2.0.21 to 2.1.0 - [Release notes](https://github.com/JetBrains/kotlin/releases) - [Changelog](https://github.com/JetBrains/kotlin/blob/master/ChangeLog.md) - [Commits](https://github.com/JetBrains/kotlin/commits) --- updated-dependencies: - dependency-name: org.jetbrains.kotlin:kotlin-gradle-plugin dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: org.jetbrains.kotlin:kotlin-stdlib-jdk7 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
…mple/androidx.lifecycle-lifecycle-viewmodel-ktx-2.8.7 Bump androidx.lifecycle:lifecycle-viewmodel-ktx from 2.5.1 to 2.8.7 in /android
…mple/kotlin_version-2.1.0 Bump kotlin_version from 2.0.21 to 2.1.0 in /android
Bumps [com.google.firebase:firebase-crashlytics](https://github.com/firebase/firebase-android-sdk) from 19.0.0 to 19.2.1. - [Commits](https://github.com/firebase/firebase-android-sdk/commits) --- updated-dependencies: - dependency-name: com.google.firebase:firebase-crashlytics dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps androidx.appcompat:appcompat from 1.6.0 to 1.7.0. --- updated-dependencies: - dependency-name: androidx.appcompat:appcompat dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
…mple/androidx.appcompat-appcompat-1.7.0 Bump androidx.appcompat:appcompat from 1.6.0 to 1.7.0 in /android
…mple/com.google.firebase-firebase-crashlytics-19.2.1 Bump com.google.firebase:firebase-crashlytics from 19.0.0 to 19.2.1 in /android
Bumps [com.google.auto.value:auto-value-annotations](https://github.com/google/auto) from 1.10.1 to 1.11.0. - [Release notes](https://github.com/google/auto/releases) - [Commits](google/auto@auto-value-1.10.1...auto-value-1.11.0) --- updated-dependencies: - dependency-name: com.google.auto.value:auto-value-annotations dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
…mple/com.google.auto.value-auto-value-annotations-1.11.0 Bump com.google.auto.value:auto-value-annotations from 1.10.1 to 1.11.0 in /android
With one main sample app and include all others as modules it's easier to maintain, see what's included and verify on CI