store/tikv: add conn pool metrics. (pingcap#3312)

hao0204 · May 23, 2017 · 9c6cd3e · 9c6cd3e
1 parent 31579bb
commit 9c6cd3e
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/store/tikv/client.go b/store/tikv/client.go
@@ -76,6 +76,7 @@ func (c *rpcClient) SendCopReq(ctx goctx.Context, addr string, req *coprocessor.
 	if err != nil {
 		return nil, errors.Trace(err)
 	}
+	connPoolHistogram.WithLabelValues("cop").Observe(time.Since(start).Seconds())
 	defer c.p.PutConn(conn)
 	msg := msgpb.Message{
 		MsgType: msgpb.MessageType_CopReq,
@@ -108,6 +109,7 @@ func (c *rpcClient) SendKVReq(ctx goctx.Context, addr string, req *kvrpcpb.Reque
 	if err != nil {
 		return nil, errors.Trace(err)
 	}
+	connPoolHistogram.WithLabelValues("kv").Observe(time.Since(start).Seconds())
 	defer c.p.PutConn(conn)
 	msg := msgpb.Message{
 		MsgType: msgpb.MessageType_KvReq,

diff --git a/store/tikv/metrics.go b/store/tikv/metrics.go
@@ -69,6 +69,15 @@ var (
 			Buckets:   prometheus.ExponentialBuckets(0.0005, 2, 18),
 		})
 
+	connPoolHistogram = prometheus.NewHistogramVec(
+		prometheus.HistogramOpts{
+			Namespace: "tidb",
+			Subsystem: "tikvclient",
+			Name:      "get_conn_seconds",
+			Help:      "Bucketed histogram of taking conn from conn pool.",
+			Buckets:   prometheus.ExponentialBuckets(0.0005, 2, 18),
+		}, []string{"type"})
+
 	sendReqHistogram = prometheus.NewHistogramVec(
 		prometheus.HistogramOpts{
 			Namespace: "tidb",
@@ -211,6 +220,7 @@ func init() {
 	prometheus.MustRegister(backoffCounter)
 	prometheus.MustRegister(backoffHistogram)
 	prometheus.MustRegister(sendReqHistogram)
+	prometheus.MustRegister(connPoolHistogram)
 	prometheus.MustRegister(coprocessorCounter)
 	prometheus.MustRegister(coprocessorHistogram)
 	prometheus.MustRegister(gcWorkerCounter)