Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tokenParams option #497

Merged
merged 2 commits into from
Mar 12, 2025
Merged

Add tokenParams option #497

merged 2 commits into from
Mar 12, 2025

Conversation

kanongil
Copy link
Contributor

This mirrors the providerParams and profileParams options, to allow custom parameters to be supplied to the token endpoint request.

This is needed by Auth0, which cannot return a JWT token without the endpoint parameter added to both the /authorize and /token request. More details here: https://auth0.com/docs/secure/tokens/access-tokens/get-access-tokens#control-access-token-audience.

Note that the existing providerParams option, seems to be confusingly named. I guess authParams would be better, but renaming it requires a breaking change.

@kanongil kanongil added the feature New functionality or improvement label Mar 11, 2025
@kanongil
Copy link
Contributor Author

The test failures does not seem related to this PR.

Marsup added a commit to hapijs/.github that referenced this pull request Mar 12, 2025
@Marsup Marsup self-assigned this Mar 12, 2025
@Marsup Marsup added this to the 13.1.0 milestone Mar 12, 2025
Copy link
Contributor

@Marsup Marsup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Marsup Marsup merged commit 23e4389 into hapijs:master Mar 12, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants