Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace image code samples with text. #196

Merged
merged 1 commit into from
Jun 14, 2019

Conversation

mbrukman
Copy link
Contributor

@mbrukman mbrukman commented Jan 6, 2019

This enables easy copy-pasting of sample code.

Also added code formatting for SQL keywords.

@bitti
Copy link

bitti commented Jan 6, 2019

Why not delete the image on this occasion?

@mbrukman
Copy link
Contributor Author

mbrukman commented Jan 6, 2019

@bitti — the image appears to be also used on http://harelba.github.io/q/ but that needs to be updated as well, but I wasn't sure how to do that, so I left it alone.

If @harelba is OK with this as well, I'm happy to delete the image in the same commit.

@bitti
Copy link

bitti commented Jan 6, 2019

@mbrukman the image might be screenshot from that site. On the site itself I see only text.

This enables easy copy-pasting of sample code.

Also added code formatting for SQL keywords.
@mbrukman mbrukman force-pushed the readme-images-to-code branch from 9538795 to 0719c6f Compare January 6, 2019 22:03
@mbrukman
Copy link
Contributor Author

mbrukman commented Jan 6, 2019

@bitti — good catch! I didn't even realize that was text on the main site and a screenshot here; I could have saved myself some time and copy-pasted from the site instead of re-creating the commands manually. 😄

Removed the image from the PR in the latest updated commit.

@mcanlas
Copy link

mcanlas commented Jan 30, 2019

Is this PR okay for merging?

@mbrukman
Copy link
Contributor Author

mbrukman commented Jan 30, 2019

@mcanlas – yes, this PR is OK for merging, at least from my perspective.

@mbrukman
Copy link
Contributor Author

@bitti, @mcanlas, @harelba – any thoughts/updates on this PR?

Copy link

@bitti bitti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine for me. But I'm a mere user of q, so I don't have a say in merging PRs.

@harelba harelba merged commit 02821fe into harelba:master Jun 14, 2019
@mbrukman mbrukman deleted the readme-images-to-code branch June 14, 2019 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants