-
-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace image code samples with text. #196
Conversation
Why not delete the image on this occasion? |
@bitti — the image appears to be also used on http://harelba.github.io/q/ but that needs to be updated as well, but I wasn't sure how to do that, so I left it alone. If @harelba is OK with this as well, I'm happy to delete the image in the same commit. |
@mbrukman the image might be screenshot from that site. On the site itself I see only text. |
This enables easy copy-pasting of sample code. Also added code formatting for SQL keywords.
9538795
to
0719c6f
Compare
@bitti — good catch! I didn't even realize that was text on the main site and a screenshot here; I could have saved myself some time and copy-pasted from the site instead of re-creating the commands manually. 😄 Removed the image from the PR in the latest updated commit. |
Is this PR okay for merging? |
@mcanlas – yes, this PR is OK for merging, at least from my perspective. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine for me. But I'm a mere user of q
, so I don't have a say in merging PRs.
This enables easy copy-pasting of sample code.
Also added code formatting for SQL keywords.