[sync] add soft cap option for DNS GetBlock response #3767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
As mentioned in #3766, the GetBlock request can be huge due to large block size. The request size is currently capped cat 4MB. But large responses are not good, and small responses are preferred. Thus, add
SoftSizeCapin GetBlock request as a soft cap for response size. The only exception is that if one block's size is greater than this value,SoftSizeCapis ignored.All changes are backward compatible.
Test
Currently, don't have a very good way to test it out. Please let me know if there any situation can reach this piece of code before launch. Thanks