Fix axis_ticks_length for the x-axis

has2k1 · Dec 16, 2024 · ed60126 · ed60126
1 parent 0ba0109
commit ed60126
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/doc/changelog.qmd b/doc/changelog.qmd
@@ -23,6 +23,9 @@ title: Changelog
 
   if the `y` aesthetic is mapped to datetime column in another layer.
 
+- Fixed bug for matplotlib>3.10 where the `axis_ticks_length` for the x-axis
+  had no effect.
+
 ## v0.14.3
 (2024-11-26)
 [![](https://zenodo.org/badge/DOI/10.5281/zenodo.14224336.svg)](https://doi.org/10.5281/zenodo.14224336)

diff --git a/plotnine/themes/themeable.py b/plotnine/themes/themeable.py
@@ -1037,7 +1037,7 @@ class axis_ticks_major_x(MixinSequenceOfValues):
     def apply_ax(self, ax: Axes):
         super().apply_ax(ax)
         params = ax.xaxis.get_tick_params(which="major")
-        if not params.get("left", False):
+        if not params.get("bottom", False):
             return
 
         tick_params = {}