This repository has been archived by the owner on Mar 19, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 16
WIP GRPC rate limiting #533
Draft
sarahalsmiller
wants to merge
17
commits into
main
Choose a base branch
from
bug/grpc-rate-limiting
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikemorris
force-pushed
the
bug/grpc-rate-limiting
branch
from
April 5, 2023 18:20
b4e4cac
to
9802d6a
Compare
mikemorris
reviewed
Apr 5, 2023
Comment on lines
+1
to
+3
```release-note:bug | ||
Use Consul Catalog API instead of Agent API to register APIGateway to prevent GRPC rate limits | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
```release-note:bug | |
Use Consul Catalog API instead of Agent API to register APIGateway to prevent GRPC rate limits | |
``` | |
```release-note:bug | |
Use Consul Catalog API instead of Agent API to register gateways in agentless deployments, to avoid gRPC rate limiting for subsequent API calls handled by Consul servers other than the one with which the gateway was registered |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
How I've tested this PR:
How I expect reviewers to test this PR:
Links
Checklist: