Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Consul ESM to support Admin Partitions #281

Merged
merged 10 commits into from
Sep 20, 2024
Merged

[Enhancement] Consul ESM to support Admin Partitions #281

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
bbccb4c
POC to check admin partition support
Sep 4, 2024
9a8746c
cleanup of the errors
Sep 5, 2024
dcf3344
cleanup of the errors
Sep 5, 2024
70f90a6
cleanup
Sep 6, 2024
74d57f8
test cleanup
Sep 16, 2024
c8a8b00
Adding more tests and code cleanup
Sep 16, 2024
b255fac
updated readme
Sep 16, 2024
cc40621
Addressing review comments
Sep 17, 2024
0b89fa4
Addressing review comments
Sep 19, 2024
033d40f
cleanup
Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test cleanup
  • Loading branch information
srahul3 committed Sep 16, 2024
commit 74d57f887615cdf5cfbb81f51ac8adc2c7049f9a
8 changes: 5 additions & 3 deletions leader_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -458,9 +458,11 @@ func Test_namespacesList(t *testing.T) {
if err != nil {
t.Fatal(err)
}

config := &Config{Partition: "default"}
// simulate enterprise consul
testcase = "ent"
nss, err := namespacesList(client)
nss, err := namespacesList(client, config)
if err != nil {
t.Fatal("unexpected error:", err)
}
Expand All @@ -469,7 +471,7 @@ func Test_namespacesList(t *testing.T) {
}
// simulate oss consul
testcase = "oss"
nss, err = namespacesList(client)
nss, err = namespacesList(client, config)
if err != nil {
t.Fatal("unexpected error:", err)
}
Expand All @@ -478,7 +480,7 @@ func Test_namespacesList(t *testing.T) {
}
// simulate other random error
testcase = "err"
nss, err = namespacesList(client)
nss, err = namespacesList(client, config)
if err == nil {
t.Fatal("unexpected error:", err)
}
Expand Down
Loading