Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store resource identities in state (TF-23255) #36464

Draft
wants to merge 38 commits into
base: main
Choose a base branch
from
Draft

Store resource identities in state (TF-23255) #36464

wants to merge 38 commits into from
+2,692 −1,171

Conversation

dbanck
Copy link
Member

@dbanck dbanck commented Feb 10, 2025 •
edited
Loading

TODO

  • Manually E2E test this against simple provider with and without resource identity
  • Write tests on e2e & unit level (we got some plan integration ones already, double check if some might be missing)
  • Handle move (cross-provider move might be tricky) -> possibly in a follow-up PR
  • Look through the naming, it's inconsistent at times

WIP

Target Release

1.12.x

CHANGELOG entry

  • This change is user-facing and I added a changelog entry.
  • This change is not user-facing.

@dbanck dbanck added the no-changelog-needed Add this to your PR if the change does not require a changelog entry label Feb 10, 2025
@github-actions GitHub Actions
Copy link
Contributor

The equivalence tests failed. Please investigate here.

@github-actions GitHub Actions
Copy link
Contributor

The equivalence tests failed. Please investigate here.

@github-actions GitHub Actions
Copy link
Contributor

The equivalence tests failed. Please investigate here.

@github-actions GitHub Actions
Copy link
Contributor

The equivalence tests failed. Please investigate here.

@github-actions GitHub Actions
Copy link
Contributor

The equivalence tests failed. Please investigate here.

@github-actions GitHub Actions
Copy link
Contributor

The equivalence tests failed. Please investigate here.

@github-actions GitHub Actions
Copy link
Contributor

The equivalence tests failed. Please investigate here.

@github-actions GitHub Actions
Copy link
Contributor

The equivalence tests failed. Please investigate here.

@github-actions GitHub Actions
Copy link
Contributor

The equivalence tests failed. Please investigate here.

@github-actions GitHub Actions
Copy link
Contributor

The equivalence tests failed. Please investigate here.

@github-actions GitHub Actions
Copy link
Contributor

The equivalence tests failed. Please investigate here.

@github-actions GitHub Actions
Copy link
Contributor

The equivalence tests failed. Please investigate here.

@github-actions GitHub Actions
Copy link
Contributor

The equivalence tests failed. Please investigate here.

@github-actions GitHub Actions
Copy link
Contributor

The equivalence tests failed. Please investigate here.

DanielMSchmidt and others added 28 commits February 28, 2025 11:53
@DanielMSchmidt @dbanck
add test case for deposed resources
6fcb9b9
@DanielMSchmidt @dbanck
clarify naming of identity data versus schema
d027d2b
@DanielMSchmidt @dbanck
add validations for identities
e0e6c35
@DanielMSchmidt @dbanck
implement resource identity schema for builtin and testing providers
ff86b5b
@DanielMSchmidt @dbanck
validate resource identity schema
841ce25
@DanielMSchmidt @dbanck
add identity schema version to assertion
7debe43
@DanielMSchmidt @dbanck
validate identity schema
889cf46
@DanielMSchmidt @dbanck
providers not supporting this API should fail silently
aa16dbb
@DanielMSchmidt @dbanck
handle external providers with preloaded schemas
cde9c9f
@DanielMSchmidt @dbanck
implement grpcwrap identity schema methods
88d543f
@DanielMSchmidt @dbanck
implement grpcwrap identity upgrade methods
f1af8b4
@DanielMSchmidt @dbanck
require all identity attributes to be specified
75c47fe
@dbanck
Move IdentityAttributes into separate file
9167afb
@dbanck
Smooth resource identity naming
49f5282
@dbanck
Rename schema.Block to Body
5c399ad
@dbanck
Use updated providers.Schema everywhere
c40d862
@dbanck
Remove preloaded resource identity schemas
eeda97f
@dbanck
Replace configschema.IdentityAttributes with Object
8bf9dbe
@dbanck
Merge identity schemas into resources
824f44b
@dbanck
Rework resource identity upgrade
8d9fbdf
@dbanck
fix identity proto conversion & fix tests
a583135
@dbanck
Add internalValidate to configschema.Object
68c37c6
@dbanck
Add back space :sadcat:
b35a934
@dbanck
Fix legacy test
c1d2886
@dbanck
make syncdeps
66f82a4
@dbanck
Fix staticcheck errors
2fab151
@dbanck
Remove global cache fixme
26baa2f
@dbanck
Remove explicit error check
8b4a42e
@dbanck dbanck force-pushed the dbanck/identity-state branch from 1bd2cd2 to 8b4a42e Compare February 28, 2025 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbardin jbardin jbardin left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
no-changelog-needed Add this to your PR if the change does not require a changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dbanck @jbardin @DanielMSchmidt